Skip to content

Commit 90c299f

Browse files
author
root
committed
Fixed ci tests created for GHSA-7pr3-p5fm-8r9x. Added verbose jasmine reporter to catch failed tests
1 parent 35ac5ba commit 90c299f

File tree

6 files changed

+33
-4
lines changed

6 files changed

+33
-4
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ jobs:
2828
NODE_VERSION: 10
2929
- name: Node 12.12.0
3030
NODE_VERSION: 12.12.0
31-
fail-fast: false
3231
name: ${{ matrix.name }}
3332
timeout-minutes: 30
3433
runs-on: ubuntu-18.04

package-lock.json

Lines changed: 10 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@
8484
"form-data": "3.0.0",
8585
"husky": "4.2.5",
8686
"jasmine": "3.5.0",
87+
"jasmine-spec-reporter": "^7.0.0",
8788
"jsdoc": "3.6.7",
8889
"jsdoc-babel": "0.5.0",
8990
"lint-staged": "10.2.3",

spec/ParseLiveQuery.spec.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -967,8 +967,10 @@ describe('ParseLiveQuery', function () {
967967
await user.save();
968968
user.set('yolo', 'bar');
969969
await user.save();
970+
user.set('foo', 'bar');
971+
await user.save();
970972
await user.destroy();
971-
await new Promise(resolve => process.nextTick(resolve));
973+
await new Promise(resolve => setTimeout(resolve, 500));
972974
for (const key of events) {
973975
expect(calls[key]).toHaveBeenCalled();
974976
}

spec/ParseUser.spec.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3967,11 +3967,17 @@ describe('Parse.User testing', () => {
39673967
await user.save();
39683968
user.set('yolo', 'bar');
39693969
await user.save();
3970+
user.unset('foo');
3971+
await user.save();
39703972
await user.destroy();
3971-
await new Promise(resolve => process.nextTick(resolve));
3973+
await new Promise(resolve => setTimeout(resolve, 500));
39723974
for (const key of events) {
39733975
expect(calls[key]).toHaveBeenCalled();
39743976
}
3977+
subscription.unsubscribe();
3978+
const client = await Parse.CoreManager.getLiveQueryController().getDefaultLiveQueryClient();
3979+
client.close();
3980+
await new Promise(resolve => setTimeout(resolve, 500));
39753981
});
39763982

39773983
describe('issue #4897', () => {

spec/helper.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,18 @@
22
// Sets up a Parse API server for testing.
33
jasmine.DEFAULT_TIMEOUT_INTERVAL = process.env.PARSE_SERVER_TEST_TIMEOUT || 5000;
44

5+
const SpecReporter = require('jasmine-spec-reporter').SpecReporter;
6+
7+
jasmine.getEnv().clearReporters(); // remove default reporter logs
8+
jasmine.getEnv().addReporter(
9+
new SpecReporter({
10+
// add jasmine-spec-reporter
11+
spec: {
12+
displayPending: true,
13+
},
14+
})
15+
);
16+
517
global.on_db = (db, callback, elseCallback) => {
618
if (process.env.PARSE_SERVER_TEST_DB == db) {
719
return callback();

0 commit comments

Comments
 (0)