Skip to content

Commit 974e903

Browse files
committed
Merge branch 'fix-lts-ci-7659' into fix-graphql-deps
2 parents d830eac + d032063 commit 974e903

File tree

6 files changed

+43
-18
lines changed

6 files changed

+43
-18
lines changed

package-lock.json

+9
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@
8484
"form-data": "3.0.0",
8585
"husky": "4.2.5",
8686
"jasmine": "3.5.0",
87+
"jasmine-spec-reporter": "7.0.0",
8788
"jsdoc": "3.6.7",
8889
"jsdoc-babel": "0.5.0",
8990
"lint-staged": "10.2.3",

spec/ParseLiveQuery.spec.js

+7-15
Original file line numberDiff line numberDiff line change
@@ -310,14 +310,10 @@ describe('ParseLiveQuery', function () {
310310
Parse.Cloud.afterLiveQueryEvent('TestObject', req => {
311311
const current = req.object;
312312
const original = req.original;
313-
314-
setTimeout(() => {
315-
done();
316-
}, 2000);
317-
318313
if (current.get('foo') != original.get('foo')) {
319314
req.sendEvent = false;
320315
}
316+
setTimeout(done, 1000);
321317
});
322318

323319
const query = new Parse.Query(TestObject);
@@ -733,9 +729,7 @@ describe('ParseLiveQuery', function () {
733729
});
734730
object.set({ foo: 'bar' });
735731
await object.save();
736-
setTimeout(async () => {
737-
done();
738-
}, 1000);
732+
setTimeout(done, 1000);
739733
});
740734

741735
it('can return a new beforeSubscribe query', async done => {
@@ -922,9 +916,9 @@ describe('ParseLiveQuery', function () {
922916
});
923917
await obj1.save();
924918
await Parse.User.logOut();
925-
await new Promise(resolve => setTimeout(resolve, 200));
919+
await new Promise(resolve => setTimeout(resolve, 100));
926920
await obj2.save();
927-
await new Promise(resolve => setTimeout(resolve, 200));
921+
await new Promise(resolve => setTimeout(resolve, 100));
928922
done();
929923
});
930924

@@ -949,7 +943,7 @@ describe('ParseLiveQuery', function () {
949943
const response = (obj, prev) => {
950944
expect(obj.get('sessionToken')).toBeUndefined();
951945
expect(obj.sessionToken).toBeUndefined();
952-
expect(prev?.sessionToken).toBeUndefined();
946+
expect(prev && prev.sessionToken).toBeUndefined();
953947
if (prev && prev.get) {
954948
expect(prev.get('sessionToken')).toBeUndefined();
955949
}
@@ -968,7 +962,7 @@ describe('ParseLiveQuery', function () {
968962
user.set('yolo', 'bar');
969963
await user.save();
970964
await user.destroy();
971-
await new Promise(resolve => process.nextTick(resolve));
965+
await new Promise(resolve => setTimeout(resolve, 10));
972966
for (const key of events) {
973967
expect(calls[key]).toHaveBeenCalled();
974968
}
@@ -978,8 +972,6 @@ describe('ParseLiveQuery', function () {
978972
const client = await Parse.CoreManager.getLiveQueryController().getDefaultLiveQueryClient();
979973
client.close();
980974
// Wait for live query client to disconnect
981-
setTimeout(() => {
982-
done();
983-
}, 1000);
975+
setTimeout(done, 10);
984976
});
985977
});

spec/ParseUser.spec.js

+6-3
Original file line numberDiff line numberDiff line change
@@ -3948,7 +3948,7 @@ describe('Parse.User testing', () => {
39483948
const response = (obj, prev) => {
39493949
expect(obj.get('authData')).toBeUndefined();
39503950
expect(obj.authData).toBeUndefined();
3951-
expect(prev?.authData).toBeUndefined();
3951+
expect(prev && prev.authData).toBeUndefined();
39523952
if (prev && prev.get) {
39533953
expect(prev.get('authData')).toBeUndefined();
39543954
}
@@ -3960,18 +3960,21 @@ describe('Parse.User testing', () => {
39603960
subscription.on(key, calls[key]);
39613961
}
39623962
const user = await Parse.User._logInWith('facebook');
3963-
39643963
user.set('foo', 'bar');
39653964
await user.save();
39663965
user.unset('foo');
39673966
await user.save();
39683967
user.set('yolo', 'bar');
39693968
await user.save();
39703969
await user.destroy();
3971-
await new Promise(resolve => process.nextTick(resolve));
3970+
await new Promise(resolve => setTimeout(resolve, 10));
39723971
for (const key of events) {
39733972
expect(calls[key]).toHaveBeenCalled();
39743973
}
3974+
subscription.unsubscribe();
3975+
const client = await Parse.CoreManager.getLiveQueryController().getDefaultLiveQueryClient();
3976+
client.close();
3977+
await new Promise(resolve => setTimeout(resolve, 10));
39753978
});
39763979

39773980
describe('issue #4897', () => {

spec/helper.js

+5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
'use strict';
2+
const CurrentSpecReporter = require('./support/CurrentSpecReporter.js');
3+
const { SpecReporter } = require('jasmine-spec-reporter');
4+
25
// Sets up a Parse API server for testing.
36
jasmine.DEFAULT_TIMEOUT_INTERVAL = process.env.PARSE_SERVER_TEST_TIMEOUT || 5000;
7+
jasmine.getEnv().addReporter(new CurrentSpecReporter());
8+
jasmine.getEnv().addReporter(new SpecReporter());
49

510
global.on_db = (db, callback, elseCallback) => {
611
if (process.env.PARSE_SERVER_TEST_DB == db) {

spec/support/CurrentSpecReporter.js

+15
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
// Sets a global variable to the current test spec
2+
// ex: global.currentSpec.description
3+
4+
global.currentSpec = null;
5+
6+
class CurrentSpecReporter {
7+
specStarted(spec) {
8+
global.currentSpec = spec;
9+
}
10+
specDone() {
11+
global.currentSpec = null;
12+
}
13+
}
14+
15+
module.exports = CurrentSpecReporter;

0 commit comments

Comments
 (0)