Skip to content

test: fix failing tests after removal of session token (#7599) #7600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Sep 30, 2021

New Pull Request Checklist

Issue Description

Backport #7599

Related issue: #7599

Approach

n/a

TODOs before merging

n/a

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 30, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza mtrezza changed the base branch from master to release-4.x.x September 30, 2021 11:45
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-4.x.x@4ac4b7f). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 5510512 differs from pull request most recent head b778c99. Consider uploading reports for the commit b778c99 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##             release-4.x.x    #7600   +/-   ##
================================================
  Coverage                 ?   93.92%           
================================================
  Files                    ?      181           
  Lines                    ?    13289           
  Branches                 ?        0           
================================================
  Hits                     ?    12482           
  Misses                   ?      807           
  Partials                 ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ac4b7f...b778c99. Read the comment docs.

@mtrezza
Copy link
Member Author

mtrezza commented Sep 30, 2021

@dblythy How strange, could you take a look why this fails when being backported to 4.x?

@dblythy
Copy link
Member

dblythy commented Sep 30, 2021

Rather odd. I can have a look tomorrow, maybe nextTick is resolving too soon?

@mtrezza
Copy link
Member Author

mtrezza commented Oct 3, 2021

It's continues to fail, I already reran the tests, so at least we know they are not just flaky tests.

The error is always the same:


Started
18
Error: Object not found.
19
    at /home/runner/work/parse-server/parse-server/lib/Controllers/DatabaseController.js:49:3084
20
    at runMicrotasks (<anonymous>)
21
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
22
(node:2827) [MONGODB DRIVER] Warning: Top-level use of w, wtimeout, j, and fsync is deprecated. Use writeConcern instead.
23
(node:2827) [MONGODB DRIVER] Warning: Current Server Discovery and Monitoring engine is deprecated, and will be removed in a future version. To use the new Server Discover and Monitoring engine, pass option { useUnifiedTopology: true } to the MongoClient constructor.
24
(node:2827) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 testafterSave listeners added to [EventEmitter]. Use emitter.setMaxListeners() to increase limit
25
(node:2827) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 testafterDelete listeners added to [EventEmitter]. Use emitter.setMaxListeners() to increase limit
26
Error: The operation was canceled.

@mtrezza
Copy link
Member Author

mtrezza commented Oct 30, 2021

Closing in favor of #7599

@mtrezza mtrezza closed this Oct 30, 2021
@mtrezza mtrezza deleted the backport-fix-tests branch October 30, 2021 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants