Skip to content

Commit 21280ac

Browse files
author
Claudéric Demers
authored
chore: update dev dependencies used for linting (clauderic#589)
1 parent 6cb7750 commit 21280ac

File tree

4 files changed

+805
-242
lines changed

4 files changed

+805
-242
lines changed

.eslintrc.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"extends": ["plugin:shopify/react"],
2+
"extends": ["plugin:shopify/react", "plugin:prettier/recommended"],
33
"rules": {
44
"no-process-env": "off",
55
"no-lonely-if": "off",

package.json

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -72,17 +72,19 @@
7272
"babel-plugin-transform-async-to-promises": "^0.8.4",
7373
"classnames": "^2.2.5",
7474
"css-loader": "^2.1.0",
75-
"eslint": "^5.16.0",
76-
"eslint-plugin-shopify": "^27.0.1",
75+
"eslint": "^6.2.1",
76+
"eslint-config-prettier": "^6.1.0",
77+
"eslint-plugin-prettier": "^3.1.0",
78+
"eslint-plugin-shopify": "^30.0.1",
7779
"extract-text-webpack-plugin": "^1.0.1",
7880
"html-webpack-plugin": "^2.16.1",
79-
"husky": "^1.3.1",
81+
"husky": "^3.0.4",
8082
"lodash": "^4.12.0",
8183
"node-sass": "^4.11.0",
8284
"postcss": "^7.0.7",
8385
"postcss-loader": "^3.0.0",
84-
"prettier": "^1.15.3",
85-
"pretty-quick": "^1.8.0",
86+
"prettier": "^1.18.2",
87+
"pretty-quick": "^1.11.1",
8688
"react": "^16.7.0",
8789
"react-addons-pure-render-mixin": "^15.0.2",
8890
"react-addons-shallow-compare": "^15.1.0",

src/SortableContainer/index.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ export default function sortableContainer(
4141

4242
validateProps(props);
4343

44-
this.state = {};
4544
this.manager = new Manager();
4645
this.events = {
4746
end: this.handleEnd,
@@ -50,6 +49,8 @@ export default function sortableContainer(
5049
};
5150
}
5251

52+
state = {};
53+
5354
static displayName = provideDisplayName('sortableList', WrappedComponent);
5455
static defaultProps = defaultProps;
5556
static propTypes = propTypes;
@@ -332,11 +333,11 @@ export default function sortableContainer(
332333
height: containerHeight,
333334
} = useWindowAsScrollContainer
334335
? {
335-
top: 0,
336-
left: 0,
337-
width: this.contentWindow.innerWidth,
338-
height: this.contentWindow.innerHeight,
339-
}
336+
top: 0,
337+
left: 0,
338+
width: this.contentWindow.innerWidth,
339+
height: this.contentWindow.innerHeight,
340+
}
340341
: this.containerBoundingRect;
341342
const containerBottom = containerTop + containerHeight;
342343
const containerRight = containerLeft + containerWidth;

0 commit comments

Comments
 (0)