Issue warning 204 at the line where the assignment appears, not at the end of function

Author: Daniel-Cortez

source/compiler/sc1.c

@@ -5080,8 +5080,11 @@ static void destructsymbols(symbol *root,int level)
       /* check that the assigned value was used, but don't show the warning
        * if the variable is completely unused (we already have warning 203 for that) */
       if ((sym->usage & (uASSIGNED | uREAD | uWRITTEN))==(uASSIGNED | uREAD | uWRITTEN)
-          && sym->vclass!=sSTATIC)
+          && sym->vclass!=sSTATIC) {
+        errorset(sSETPOS,sym->lnumber);
         error(204,sym->name);   /* symbol is assigned a value that is never used */
+        errorset(sSETPOS,-1);
+      } /* if */
     } /* if */
     sym=sym->next;
   } /* while */

source/compiler/tests/warning_240.meta

@@ -3,10 +3,10 @@
   'errors': """
 warning_240.pwn(11) : warning 240: previously assigned value is never used (symbol "local_var")
 warning_240.pwn(12) : warning 240: previously assigned value is never used (symbol "local_var")
-warning_240.pwn(18) : warning 204: symbol is assigned a value that is never used: "local_var"
+warning_240.pwn(14) : warning 204: symbol is assigned a value that is never used: "local_var"
+warning_240.pwn(23) : warning 240: previously assigned value is never used (symbol "local_static_var")
 warning_240.pwn(24) : warning 240: previously assigned value is never used (symbol "local_static_var")
-warning_240.pwn(25) : warning 240: previously assigned value is never used (symbol "local_static_var")
-warning_240.pwn(51) : warning 240: previously assigned value is never used (symbol "arg")
-warning_240.pwn(51) : warning 204: symbol is assigned a value that is never used: "arg"
+warning_240.pwn(50) : warning 240: previously assigned value is never used (symbol "arg")
+warning_240.pwn(50) : warning 204: symbol is assigned a value that is never used: "arg"
 """
 }

source/compiler/tests/warning_240.pwn

@@ -8,21 +8,20 @@ test_local()
 {
 	new local_var;
 	local_var = 1;
-	local_var = 2; // warning
-	local_var = 3; // warning
+	local_var = 2; // warning 240
+	local_var = 3; // warning 240
 	#pragma unused local_var
-	local_var = 4;
+	local_var = 4; // warning 204
 	new local_var2 = 0;
 	local_var2 = 1;
 	#pragma unused local_var2
-} // warning (value assigned to "local_var"
-  // wasn't used upon symbol destruction)
+}
 
 test_local_static()
 {
 	static local_static_var = 0;
-	local_static_var = 1; // warning
-	local_static_var = 2; // warning
+	local_static_var = 1; // warning 240
+	local_static_var = 2; // warning 240
 	#pragma unused local_static_var
 	local_static_var = 4;
 }
@@ -48,7 +47,7 @@ test_global_static()
 test_arg(arg)
 {
 	arg = 0;
-	arg = 1; // warning (240, 204)
+	arg = 1; // warning 240, warning 204
 }
 
 main()