Skip to content

Redact variables value with "password/token" in Server install logs #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rmartinoscar opened this issue Feb 22, 2025 · 0 comments · May be fixed by #80
Open

Redact variables value with "password/token" in Server install logs #76

rmartinoscar opened this issue Feb 22, 2025 · 0 comments · May be fixed by #80

Comments

@rmartinoscar
Copy link
Contributor

Thought we could leverage this

wings/server/server.go

Line 171 in 0566b83

func parseInvocation(invocation string, envvars map[string]interface{}, memory int64, port int, ip string) (parsed string) {

then once those are redacted we could even send details in server.InstallCompletedEvent so you can have complete install logs on the panel (we would also have to redact those in the output).
Then the Panel will filter out which KeyValue to show the user based on if the variable is viewable.
@QuintenQVD0 QuintenQVD0 linked a pull request Mar 22, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Redact values of ENV variables in the install logs QuintenQVD0/wings
1 participant
@rmartinoscar