-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Support for Edge #2076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes please. I like Chrome and Vimium, but Chrome burns through battery faster. |
Yeah guys, I've made the switch to MS Edge after the anniversary update and I would love to have Vimium on it. |
same here... waiting for vimium before switching to MS Edge |
+1. Vimium is the only thing that keeps me on Chrome |
Microsoft introduced a tool to convert Chrome extension to an Edge extension. |
Has there been any progress on this? It would be a nice feature. |
So no love for Edge? No acknowledgment even fro the devs :( |
+1 |
I've found this project: https://github.com/iscriptology/edge-vimium It seems abandoned. I managed to launch it on Edge but there are many bugs. I will try to work on it in my free time here: https://github.com/KonradJanica/edge-vimium |
awesome, thanks. I'll see if I can contribute as well. I hate bloated Chrome |
Konrad, why fork as oppose to contributing directly to the project? It seems that people keep improving it. |
I forked it because I assume it is abandoned considering that I have an outstanding pull request for almost 3 weeks now |
I see, didn't know that |
either way you'll need to fork it to make changes. @KonradJanica please open pull requests if you make changes. It'd be nice to have a single plugin to which everyone contributes. |
@KonradJanica... The project is absolutely not abandoned. I'm just a bit busy with other stuff right now. There's a fair few of my own PRs sitting in the queue too. Vimium will get more of my time in a couple of weeks. |
@smblott-github I was talking about the Edge version of vimium in the repo here: https://github.com/iscriptology/edge-vimium |
@KonradJanica I saw your PR it just wasn't significant enough to merge. Please make a PR once your fork is starting to mature. |
I really really really wait in hope for Edge's vimium. |
@zhouyangnk Yeah good luck with that :) |
We're investigating support for Firefox in #2425, and will consider Edge based on the lessons learned from shipping and maintaining support for Firefox. |
Any news on this? |
Ping. This is a deal breaker for edge for me. Would be awesome to have similar functionality in the edge browser. Edit: Not to say that its your job to make edge better :) |
To get a bare bones port running, we'll need some stubs for the Chrome APIs. If someone running Windows can grab the latest stub files ( |
I'll try to take a look at it tonight and update. Would the best strategy be to create a fork and pull request so we can iterate? |
That sounds like the best way to go, yes. |
I've put the latest version of the API compatability layer in this gist. |
Any news here guys? Anything I can do to help? Edge has become such a good browser I see no reason to install Chrome anymore except for this plugin :( |
I've tested getting (very) basic support in my branch here (tracking via PR mrmr1993#9). To test, check out that branch, build it (instructions) and then add to Edge. This isn't a priority for me (I don't run Windows or use Edge) so please anybody feel free to jump in and try to improve things. My tracking PR has a list of the obvious things that would benefit from fixes. |
ping |
Yeah I know someone just has to go do it. Funny thing is I'm liking Edge more and more it has matured a lot and a quite a bit faster then Chrome now but I'm really missing this plug in. |
I wonder does it change anything now the fact that Chromium Edge is out. Did anyone look into it? How easy is it to load Chrome addons in Chromium Edge now? |
The Edge Insider based on Chromium can load Chrome extensions directly and perfectly. |
Yayy!, it work on Microsoft Edge Chromium ! |
I wonder if vimium could add support for edge "collections" |
should this issue be closed, considering that Edge is Chromium-based now? |
Yes |
Thanks. I'll close this in favor of #4211. I do intend to publish Vimium to the Edge Addons site. |
Cross posting here, even though I posted this on #4211: Hey folks, Vimium is now on the Edge Add-ons site. Please leave a review there to help encourage others to try it. Thanks! |
@philc congrats for reaching this awesome milestone :) Now we need to make it work on Firefox :) |
Could you guys please consider adding support for MS Edge? All the blogs I see say that most Chrome extensions could be changed support Edge with minimal 1 line changes.
The text was updated successfully, but these errors were encountered: