Skip to content

Focus Indicator not returning to previous status from modal #11258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
israelcefrin opened this issue Apr 10, 2025 · 1 comment
Open

Focus Indicator not returning to previous status from modal #11258

israelcefrin opened this issue Apr 10, 2025 · 1 comment
Assignees
Labels
Accessibility Any issue that impacts assistive technology or users with visual or physical impairments.

Comments

@israelcefrin
Copy link
Contributor

Issue Description

When an editor opens a modal clicking on the Viewbutton from actions column, it opens the modal with the submission details. When they close the modal, the focus goes to the first interactive element of the page.

How to reproduce / Current behavior

  1. Log in to an OJS journal
  2. Navigate using the TAB key to reach a View button
  3. Activate the button using ENTER key
  4. Close the modal pressing ESC key
  5. Press TAB and see that the focus indicator is back to the journal name at the top

What application are you using?

OJS version 3.5.rc2

Stack used

  • Device: laptop
  • OS: Macos Sequoia
  • Browser: Edge
  • Version: 135.0.3179.54 (Official build) (arm64)

Testing method

  • Method: Manual, Keyboard

Action

When closing the modal, the focus should return to the button that triggered the modal.

Additional information

Original state of focus (on the View button)
Image

Modal

Image

New focus position after closing the modal
Image

@israelcefrin israelcefrin added the Accessibility Any issue that impacts assistive technology or users with visual or physical impairments. label Apr 10, 2025
@jardakotesovec
Copy link
Contributor

Thanks @israelcefrin .

For reference upstream issue: tailwindlabs/headlessui#3686

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Any issue that impacts assistive technology or users with visual or physical impairments.
Projects
Status: No status
Development

No branches or pull requests

2 participants