Skip to content

Commit 425e17e

Browse files
KyoheiG3KyoheiG3
authored
Merge pull request #117 from akaboshinit/fix-analysis-warning
fix: analysis warning
2 parents a20d5d8 + 2374e66 commit 425e17e

14 files changed

+112
-85
lines changed

‎analysis_options.yaml

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
include: package:very_good_analysis/analysis_options.5.1.0.yaml
22

3+
analyzer:
4+
exclude:
5+
- '**/generated_playbook.dart'
6+
37
linter:
48
rules:
59
sort_pub_dependencies: false

‎examples/generator_app/lib/bar/bar.dart

+5-5
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,22 @@ import 'package:flutter/material.dart';
22

33
class BarWidget extends StatelessWidget {
44
const BarWidget({
5+
super.key,
56
required this.text,
67
});
78

89
final String text;
910

1011
@override
1112
Widget build(BuildContext context) {
12-
return Container(
13+
return ColoredBox(
1314
color: Colors.amberAccent,
1415
child: Row(
1516
mainAxisAlignment: MainAxisAlignment.center,
16-
crossAxisAlignment: CrossAxisAlignment.center,
1717
children: [
18-
Icon(Icons.star),
19-
SizedBox(width: 16),
20-
Text(text, style: Theme.of(context).textTheme.headlineSmall)
18+
const Icon(Icons.star),
19+
const SizedBox(width: 16),
20+
Text(text, style: Theme.of(context).textTheme.headlineSmall),
2121
],
2222
),
2323
);

‎examples/generator_app/lib/bar/bar.story.dart

+3-4
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,17 @@
1+
import 'package:generator_app/bar/bar.dart';
12
import 'package:playbook/playbook.dart';
23

3-
import 'bar.dart';
4-
54
const storyTitle = 'BarWidget';
65

76
Scenario twoLineText() {
8-
return Scenario(
7+
return const Scenario(
98
'TwoLine',
109
child: BarWidget(text: 'TextTextText\nTextText'),
1110
);
1211
}
1312

1413
Scenario emptyText() {
15-
return Scenario('Empty', child: BarWidget(text: ''));
14+
return const Scenario('Empty', child: BarWidget(text: ''));
1615
}
1716

1817
List<Scenario> variousText() {

‎examples/generator_app/lib/foo/foo_widget.story.dart

+7-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// ignore_for_file: camel_case_types
2+
13
import 'package:flutter/material.dart';
24
import 'package:playbook/playbook.dart';
35

@@ -25,6 +27,8 @@ Scenario foo2() {
2527
),
2628
)
2729
class Foo3 extends StatelessWidget {
30+
const Foo3({super.key});
31+
2832
@override
2933
Widget build(BuildContext context) {
3034
return Container(color: Colors.amber);
@@ -38,6 +42,8 @@ class Foo3 extends StatelessWidget {
3842
),
3943
)
4044
class $Foo4_Bar extends StatelessWidget {
45+
const $Foo4_Bar({super.key});
46+
4147
@override
4248
Widget build(BuildContext context) {
4349
return Container(color: Colors.pink);
@@ -50,4 +56,4 @@ class $Foo4_Bar extends StatelessWidget {
5056
crossAxisLayout: ScenarioLayoutFixed(200),
5157
),
5258
)
53-
Widget $foo5() => Text('Foo 5');
59+
Widget $foo5() => const Text('Foo 5');

‎examples/generator_app/lib/image/asset_image.story.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const storyTitle = 'AssetImage';
88
Widget $AssetImage() => Image.asset('assets/flutter.png');
99

1010
@GenerateScenario()
11-
Widget $MaterialIcon() => Icon(Icons.access_alarm);
11+
Widget $MaterialIcon() => const Icon(Icons.access_alarm);
1212

1313
@GenerateScenario()
14-
Widget $CupertinoIcon() => Icon(CupertinoIcons.alarm);
14+
Widget $CupertinoIcon() => const Icon(CupertinoIcons.alarm);

‎examples/generator_app/lib/page/page.story.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
import 'package:generator_app/page/page.dart';
21
import 'package:flutter/material.dart';
2+
import 'package:generator_app/page/page.dart';
33
import 'package:playbook/playbook.dart';
44

55
const storyTitle = 'HomePage';
66

77
@GenerateScenario()
8-
Widget myPage() => HomePage(title: 'Home Page');
8+
Widget myPage() => const HomePage(title: 'Home Page');

‎examples/generator_app/test/snapshot_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import 'package:playbook_snapshot/playbook_snapshot.dart';
66
Future<void> main() async {
77
testWidgets('Take snapshots', (tester) async {
88
await playbook.run(
9-
Snapshot(
9+
const Snapshot(
1010
devices: [
1111
SnapshotDevice.iPhoneSE2nd,
1212
],

‎examples/simple_app/lib/bar/bar.dart

+5-5
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,22 @@ import 'package:flutter/material.dart';
22

33
class BarWidget extends StatelessWidget {
44
const BarWidget({
5+
super.key,
56
required this.text,
67
});
78

89
final String text;
910

1011
@override
1112
Widget build(BuildContext context) {
12-
return Container(
13+
return ColoredBox(
1314
color: Colors.amberAccent,
1415
child: Row(
1516
mainAxisAlignment: MainAxisAlignment.center,
16-
crossAxisAlignment: CrossAxisAlignment.center,
1717
children: [
18-
Icon(Icons.star),
19-
SizedBox(width: 16),
20-
Text(text, style: Theme.of(context).textTheme.headlineSmall)
18+
const Icon(Icons.star),
19+
const SizedBox(width: 16),
20+
Text(text, style: Theme.of(context).textTheme.headlineSmall),
2121
],
2222
),
2323
);

‎examples/simple_app/lib/bar/bar.story.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@ import 'package:playbook/playbook.dart';
22
import 'package:simple_app/bar/bar.dart';
33

44
Scenario twoLineText() {
5-
return Scenario(
5+
return const Scenario(
66
'TwoLine',
77
child: BarWidget(text: 'TextTextText\nTextText'),
88
);
99
}
1010

1111
Scenario emptyText() {
12-
return Scenario('Empty', child: BarWidget(text: ''));
12+
return const Scenario('Empty', child: BarWidget(text: ''));
1313
}
1414

1515
List<Scenario> variousText() {

‎examples/simple_app/lib/foo/foo_widget.story.dart

+39-30
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
// ignore_for_file: camel_case_types
2+
13
import 'package:flutter/material.dart';
24
import 'package:playbook/playbook.dart';
35

@@ -16,54 +18,61 @@ Scenario foo2() {
1618
}
1719

1820
class Foo3 extends StatelessWidget {
21+
const Foo3({super.key});
22+
1923
@override
2024
Widget build(BuildContext context) {
2125
return Container(color: Colors.amber);
2226
}
2327
}
2428

2529
class Foo4_Bar extends StatelessWidget {
30+
const Foo4_Bar({super.key});
31+
2632
@override
2733
Widget build(BuildContext context) {
2834
return Container(color: Colors.pink);
2935
}
3036
}
3137

32-
Widget foo5() => Text('Foo 5');
38+
Widget foo5() => const Text('Foo 5');
3339

3440
Story fooWidgetStory() {
35-
return Story('FooWidget', scenarios: [
36-
foo1(),
37-
foo2(),
38-
Scenario(
39-
'foo3foo3',
40-
layout: ScenarioLayout.sizing(
41-
ScenarioLayoutFixed(
42-
100.0,
43-
),
44-
ScenarioLayoutFixed(
45-
200.0,
41+
return Story(
42+
'FooWidget',
43+
scenarios: [
44+
foo1(),
45+
foo2(),
46+
const Scenario(
47+
'foo3foo3',
48+
layout: ScenarioLayout.sizing(
49+
ScenarioLayoutFixed(
50+
100,
51+
),
52+
ScenarioLayoutFixed(
53+
200,
54+
),
4655
),
56+
child: Foo3(),
4757
),
48-
child: Foo3(),
49-
),
50-
Scenario(
51-
'Foo4 Bar',
52-
layout: ScenarioLayout.fixedH(
53-
300.0,
54-
crossAxisLayout: ScenarioLayoutFill(),
58+
const Scenario(
59+
'Foo4 Bar',
60+
layout: ScenarioLayout.fixedH(
61+
300,
62+
crossAxisLayout: ScenarioLayoutFill(),
63+
),
64+
child: Foo4_Bar(),
5565
),
56-
child: Foo4_Bar(),
57-
),
58-
Scenario(
59-
'foo5',
60-
layout: ScenarioLayout.fixedV(
61-
500.0,
62-
crossAxisLayout: ScenarioLayoutFixed(
63-
200.0,
66+
Scenario(
67+
'foo5',
68+
layout: const ScenarioLayout.fixedV(
69+
500,
70+
crossAxisLayout: ScenarioLayoutFixed(
71+
200,
72+
),
6473
),
74+
child: foo5(),
6575
),
66-
child: foo5(),
67-
),
68-
]);
76+
],
77+
);
6978
}

‎examples/simple_app/lib/image/asset_image.story.dart

+17-14
Original file line numberDiff line numberDiff line change
@@ -5,18 +5,21 @@ import 'package:playbook/playbook.dart';
55
Widget assetImage() => Image.asset('assets/flutter.png');
66

77
Story assetImageStory() {
8-
return Story('AssetImage', scenarios: [
9-
Scenario(
10-
'AssetImage',
11-
child: assetImage(),
12-
),
13-
Scenario(
14-
'MaterialIcon',
15-
child: Icon(Icons.access_alarm),
16-
),
17-
Scenario(
18-
'CupertinoIcon',
19-
child: Icon(CupertinoIcons.alarm),
20-
)
21-
]);
8+
return Story(
9+
'AssetImage',
10+
scenarios: [
11+
Scenario(
12+
'AssetImage',
13+
child: assetImage(),
14+
),
15+
const Scenario(
16+
'MaterialIcon',
17+
child: Icon(Icons.access_alarm),
18+
),
19+
const Scenario(
20+
'CupertinoIcon',
21+
child: Icon(CupertinoIcons.alarm),
22+
),
23+
],
24+
);
2225
}

‎examples/simple_app/lib/page/page.story.dart

+10-7
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,14 @@
1-
import 'package:simple_app/page/page.dart';
21
import 'package:playbook/playbook.dart';
2+
import 'package:simple_app/page/page.dart';
33

44
Story homePageStory() {
5-
return Story('HomePage', scenarios: [
6-
Scenario(
7-
'myPage',
8-
child: HomePage(title: 'Home Page'),
9-
),
10-
]);
5+
return const Story(
6+
'HomePage',
7+
scenarios: [
8+
Scenario(
9+
'myPage',
10+
child: HomePage(title: 'Home Page'),
11+
),
12+
],
13+
);
1114
}

‎examples/simple_app/lib/scrollable/scrollable.story.dart

+14-11
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,18 @@
1-
import 'package:simple_app/scrollable/scrollable.dart';
21
import 'package:playbook/playbook.dart';
2+
import 'package:simple_app/scrollable/scrollable.dart';
33

44
Story scrollableStory() {
5-
return Story('Scrollable', scenarios: [
6-
Scenario(
7-
'Primary Scrollable',
8-
child: scrollable(primary: true),
9-
),
10-
Scenario(
11-
'Not Primary Scrollable',
12-
child: scrollable(primary: false),
13-
)
14-
]);
5+
return Story(
6+
'Scrollable',
7+
scenarios: [
8+
Scenario(
9+
'Primary Scrollable',
10+
child: scrollable(primary: true),
11+
),
12+
Scenario(
13+
'Not Primary Scrollable',
14+
child: scrollable(primary: false),
15+
),
16+
],
17+
);
1518
}

‎examples/simple_app/test/snapshot_test.dart

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Future<void> main() async {
1919
scrollableStory(),
2020
],
2121
).run(
22-
Snapshot(
22+
const Snapshot(
2323
devices: [
2424
SnapshotDevice.iPhoneSE2nd,
2525
],

0 commit comments

Comments
 (0)