Skip to content

Commit 7cc4dfc

Browse files
committed
move string comparison outside for loop
1 parent a54c502 commit 7cc4dfc

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

src/components/modebar/buttons.js

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,6 +390,9 @@ modeBarButtons.resetCameraLastSave3d = {
390390
function handleCamera3d(gd, ev) {
391391
var button = ev.currentTarget;
392392
var attr = button.getAttribute('data-attr');
393+
var resetLastSave = attr === 'resetLastSave';
394+
var resetDefault = attr === 'resetDefault';
395+
393396
var fullLayout = gd._fullLayout;
394397
var sceneIds = fullLayout._subplots.gl3d || [];
395398
var aobj = {};
@@ -402,12 +405,12 @@ function handleCamera3d(gd, ev) {
402405
var scene = fullLayout[sceneId]._scene;
403406
var didUpdate;
404407

405-
if(attr === 'resetLastSave') {
408+
if(resetLastSave) {
406409
aobj[camera + '.up'] = scene.viewInitial.up;
407410
aobj[camera + '.eye'] = scene.viewInitial.eye;
408411
aobj[camera + '.center'] = scene.viewInitial.center;
409412
didUpdate = true;
410-
} else if(attr === 'resetDefault') {
413+
} else if(resetDefault) {
411414
aobj[camera + '.up'] = null;
412415
aobj[camera + '.eye'] = null;
413416
aobj[camera + '.center'] = null;

0 commit comments

Comments
 (0)