fix: address code review issues

-   fix black exclude parameter in pyproject.toml to properly exclude ONLY directories
-   reintroduce py38 in codegen/__init__.py
-   remove commented-out lines
-   add plotly/validators/_validators.json to pyproject.toml
-   regenerate code

Author: emilykl

README.md

@@ -55,7 +55,7 @@ See the [Python documentation](https://plotly.com/python/) for more examples.
 
 Built on top of [plotly.js](https://github.com/plotly/plotly.js), `plotly.py` is a high-level, declarative charting library. plotly.js ships with over 30 chart types, including scientific charts, 3D graphs, statistical charts, SVG maps, financial charts, and more.
 
-`plotly.py` is [MIT Licensed](https://github.com/plotly/plotly.py/blob/main/LICENSE.txt). Plotly graphs can be viewed in Jupyter and marimo notebooks, standalone HTML files, or integrated into [Dash applications](https://dash.plotly.com/).
+`plotly.py` is [MIT Licensed](https://github.com/plotly/plotly.py/blob/main/LICENSE.txt). Plotly graphs can be viewed in [Jupyter notebooks](https://jupyter.org), other Python notebook software such as [marimo](https://marimo.io), as standalone HTML files, or integrated into [Dash applications](https://dash.plotly.com/).
 
 [Contact us](https://plotly.com/consulting-and-oem/) for consulting, dashboard development, application integration, and feature additions.
 

codegen/__init__.py

@@ -29,7 +29,7 @@
 
 # Target Python version for code formatting with Black.
 # Must be one of the values listed in pyproject.toml.
-BLACK_TARGET_VERSIONS = "py39 py310 py311 py312"
+BLACK_TARGET_VERSIONS = "py38 py39 py310 py311 py312"
 
 
 # Import notes

codegen/validators.py

@@ -85,7 +85,6 @@ def write_validator_json(outdir, params: dict):
     filepath = opath.join(outdir, "validators", "_validators.json")
     with open(filepath, "w") as f:
         f.write(json.dumps(params, indent=4))
-        # f.write(str(params))
 
 
 def build_data_validator_params(base_trace_node: TraceNode):

plotly/basedatatypes.py

@@ -470,10 +470,9 @@ class is a subclass of both BaseFigure and widgets.DOMWidget.
         """
         from .validator_cache import ValidatorCache
 
-        DataValidator = ValidatorCache.get_validator("", "data")
-        FramesValidator = ValidatorCache.get_validator("", "frames")
-        LayoutValidator = ValidatorCache.get_validator("", "layout")
-        # from .validators import DataValidator, LayoutValidator, FramesValidator
+        data_validator = ValidatorCache.get_validator("", "data")
+        frames_validator = ValidatorCache.get_validator("", "frames")
+        layout_validator = ValidatorCache.get_validator("", "layout")
 
         super(BaseFigure, self).__init__()
 
@@ -526,8 +525,8 @@ class is a subclass of both BaseFigure and widgets.DOMWidget.
         # This is the validator that handles importing sequences of trace
         # objects
         # We make a copy because we are overriding the set_uid attribute
-        # and do not want to alter all other uses of the cached DataValidator
-        self._data_validator = copy(DataValidator)
+        # and do not want to alter all other uses of the cached data_validator
+        self._data_validator = copy(data_validator)
         self._data_validator.set_uid = self._set_trace_uid
 
         # ### Import traces ###
@@ -571,7 +570,7 @@ class is a subclass of both BaseFigure and widgets.DOMWidget.
         # ------
         # ### Construct layout validator ###
         # This is the validator that handles importing Layout objects
-        self._layout_validator = LayoutValidator
+        self._layout_validator = layout_validator
 
         # ### Import Layout ###
         self._layout_obj = self._layout_validator.validate_coerce(
@@ -606,7 +605,7 @@ class is a subclass of both BaseFigure and widgets.DOMWidget.
         # ### Construct frames validator ###
         # This is the validator that handles importing sequences of frame
         # objects
-        self._frames_validator = FramesValidator
+        self._frames_validator = frames_validator
 
         # ### Import frames ###
         self._frame_objs = self._frames_validator.validate_coerce(

pyproject.toml

@@ -63,15 +63,15 @@ plotly = [
     "package_data/*",
     "package_data/templates/*",
     "package_data/datasets/*",
+    "plotly/validators/_validators.json"
 ]
 
 [tool.black]
 line-length = 88
 target_version = ['py38', 'py39', 'py310', 'py311', 'py312']
 include = '\.pyi?$'
 exclude = '''
-
-(
+/(
       \.eggs         # exclude a few common directories in the
     | \.git          # root of the project
     | \.hg
@@ -85,7 +85,7 @@ exclude = '''
     | js
     | submodules
     | plotly/matplotlylib/mplexporter
-)
+)/
 '''
 
 [tool.jupyter-packaging.builder]