Skip to content

Commit bec81a3

Browse files
juanespjmfreeborn
andauthored
plot.show() fix (#129)
* plot.show() fix Moved a few things around I got this to work on my Windows 10 machine seems like Spawn() does the trick!! * Revert "plot.show() fix" This reverts commit 780976a. * fix plot.show() Windows Hi, sorry for the last PR updated!! * fix command line args * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Michael Freeborn <[email protected]>
1 parent 712bee6 commit bec81a3

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.
33

44
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
55

6+
## [0.8.4] - 2023-01-xx
7+
### Fixed
8+
- [[#129](https://github.com/igiagkiozis/plotly/pull/129)] Fix issue for plots not showing in browser in Windows. Thanks to [@juanespj](https://github.com/juanespj) for the PR.
9+
610
## [0.8.3] - 2022-11-04
711
### Fixed
812
- [[#122](https://github.com/igiagkiozis/plotly/pull/122)] Compilation error for the `wasm` feature.

plotly/src/plot.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -466,8 +466,8 @@ impl Plot {
466466
use std::process::Command;
467467
Command::new("cmd")
468468
.arg("/C")
469-
.arg(format!(r#"start {}"#, temp_path))
470-
.output()
469+
.arg(format!("start {}", temp_path))
470+
.spawn()
471471
.expect(DEFAULT_HTML_APP_NOT_FOUND);
472472
}
473473
}

0 commit comments

Comments
 (0)