Skip to content

MSRV is not accurate #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NZRosto opened this issue Apr 9, 2025 · 1 comment · Fixed by #381
Closed

MSRV is not accurate #380

NZRosto opened this issue Apr 9, 2025 · 1 comment · Fixed by #381

Comments

@NZRosto
Copy link

NZRosto commented Apr 9, 2025

Hi all,

The Minimum Supported Rust Version (MSRV) in Cargo.toml no longer appears to be accurate. This seems to be due to the use of BuildHasherDefault::new() here which was only introduced in Rust 1.85. Other issues may be present though.

Output of cargo-msrv:

  [Meta]   cargo-msrv 0.18.4  

Compatibility Check #1: Rust 1.75.0
  [FAIL]   Is incompatible 

Checking cosmic-text v0.14.1
   error[E0599]: no function or associated item named `new` found for struct `BuildHasherDefault` in the current scope
      --> src/font/fallback/mod.rs:112:75
       |
   112 |             HashMap::with_capacity_and_hasher(scripts.len(), BuildHasher::new());
       |                                                                           ^^^ function or associated item not found in `BuildHasherDefault<FxHasher>` 

   For more information about this error, try `rustc --explain E0599`.
   error: could not compile `cosmic-text` (lib) due to previous error

Crate source was found to be incompatible with Rust version '1.75.0' specified as MSRV in the Cargo manifest located at './Cargo.toml'

Possible solutions:

  • Remove code that relies on a more recent version of Rust
  • Upgrade the MSRV to 1.85 (Not my preferred option: I am required to use an older version of Rust for one of my projects, which is how I discovered this issue)

It may also be useful in the future to include a CI build on the MSRV to ensure there aren't any regressions (from what I can tell the CI jobs currently just run on the most recent version of Rust?).

Thanks everyone involved in this great project!

@jackpot51
Copy link
Member

Releases as 0.14.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants