Skip to content

method assumes virtual methods always start with an underscore #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
geekrelief opened this issue Feb 3, 2021 · 3 comments · May be fixed by #88
Closed

method assumes virtual methods always start with an underscore #87

geekrelief opened this issue Feb 3, 2021 · 3 comments · May be fixed by #88

Comments

@geekrelief
Copy link
Contributor

Example:
EditorPlugin.has_main_screen is a virtual method, but does not have an underscore.
https://docs.godotengine.org/en/stable/classes/class_editorplugin.html#class-editorplugin-method-has-main-screen

method hasMainScreen():bool = true

use of method on a proc assumes it's virtual

godot-nim/godot/nim/godotmacros.nim

Line 165 in 388bea9

isVirtual: meth.kind == nnkMethodDef,

and gdobj prepends an underscore to all method names.

godot-nim/godot/nim/godotmacros.nim

Line 608 in 388bea9

let godotMethodName = if meth.isVirtual: "_" & toGodotStyle(meth.name)

As a work around to override the virtual function you declare it as proc with gdExport like:

proc hasMainScreen():bool {.gdExport.} =
  true
@endragor
Copy link
Member

endragor commented Feb 3, 2021

You can override the name selected by default, like this: {.gdExport: "has_main_screen".}.
methods are exported with _ prepended by default, because that's the convention Godot mostly follows itself. Yes, it's not always that way, and you can override it where needed. If not for this default, you'd have to do method process() {.gdExport: "_process".} everywhere, which is annoying.

@geekrelief
Copy link
Contributor Author

I just tried passing a param as you suggested, and it doesn't work. I must be missing something because I don't see where that's happening in godotmacros.nim. I see hint and hintStr using removeStrPragma to get the value, but gdExport is using removePragma:

godot-nim/godot/nim/godotmacros.nim

Line 142 in 388bea9

let isGdExport = removePragma(nameNode, "gdExport")

godot-nim/godot/nim/godotmacros.nim

Line 158 in 388bea9

let isGdExport = removePragma(meth, "gdExport")

@endragor
Copy link
Member

endragor commented Feb 3, 2021

Ah, maybe I confused this with another project. Well, then I think the way it's described in my previous comment is how this should be resolved.

@geekrelief geekrelief mentioned this issue Feb 4, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gdexport on method exports without transforming geekrelief/godot-nim
2 participants
@geekrelief @endragor