From ef5cbd089d2de6d19720cdd4a0a16401e4fafae5 Mon Sep 17 00:00:00 2001 From: Van Anderson Date: Tue, 1 Jun 2021 11:51:10 -0500 Subject: [PATCH 1/3] data-test-id can be used with OverlayProps --- src/Overlay.tsx | 1 + src/stories/ActionMenu.stories.tsx | 1 + 2 files changed, 2 insertions(+) diff --git a/src/Overlay.tsx b/src/Overlay.tsx index 06dc8ae2161..f7f85b223f6 100644 --- a/src/Overlay.tsx +++ b/src/Overlay.tsx @@ -65,6 +65,7 @@ export type OverlayProps = { onClickOutside: (e: TouchOrMouseEvent) => void onEscape: (e: KeyboardEvent) => void visibility?: 'visible' | 'hidden' + 'data-test-id'?: string } & Omit, 'visibility' | keyof SystemPositionProps> /** diff --git a/src/stories/ActionMenu.stories.tsx b/src/stories/ActionMenu.stories.tsx index d682603afb9..435abf4743d 100644 --- a/src/stories/ActionMenu.stories.tsx +++ b/src/stories/ActionMenu.stories.tsx @@ -97,6 +97,7 @@ export function SimpleListStory(): JSX.Element { onAction={onAction} anchorContent="Menu" overlayProps={{ + 'data-test-id': 'some_test_id', onMouseDown: (e: React.MouseEvent) => // eslint-disable-next-line no-console console.log('onMouseDown in the internal Overlay can be useful for controlling event interactions', e) From 8f592ea0161f101616d8fa2c3a0920a174f29499 Mon Sep 17 00:00:00 2001 From: Van Anderson Date: Tue, 8 Jun 2021 15:59:56 -0500 Subject: [PATCH 2/3] overlayProps can have additional keys --- src/Overlay.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Overlay.tsx b/src/Overlay.tsx index f7f85b223f6..4565aae88b7 100644 --- a/src/Overlay.tsx +++ b/src/Overlay.tsx @@ -65,7 +65,7 @@ export type OverlayProps = { onClickOutside: (e: TouchOrMouseEvent) => void onEscape: (e: KeyboardEvent) => void visibility?: 'visible' | 'hidden' - 'data-test-id'?: string + [additionalKey: string]: unknown } & Omit, 'visibility' | keyof SystemPositionProps> /** From 90227725e9e85b4f5141926cad479c49657068f7 Mon Sep 17 00:00:00 2001 From: Van Anderson Date: Wed, 9 Jun 2021 15:18:49 -0500 Subject: [PATCH 3/3] Create cool-rocks-drive.md --- .changeset/cool-rocks-drive.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/cool-rocks-drive.md diff --git a/.changeset/cool-rocks-drive.md b/.changeset/cool-rocks-drive.md new file mode 100644 index 00000000000..331f2030bf7 --- /dev/null +++ b/.changeset/cool-rocks-drive.md @@ -0,0 +1,5 @@ +--- +"@primer/components": patch +--- + +data props can be used in overlayProps.