Skip to content

Highlights need more contrast. Specially in dark mode. #6797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adriancuadrado opened this issue Apr 4, 2025 · 0 comments · Fixed by #6815 · May be fixed by #6798
Closed

Highlights need more contrast. Specially in dark mode. #6797

adriancuadrado opened this issue Apr 4, 2025 · 0 comments · Fixed by #6815 · May be fixed by #6798
Assignees
@aidankmcalister
Labels
docs Documentation creation, updates or corrections

Comments

@adriancuadrado
Copy link
Contributor

I can barely tell what is being highlighted here.

Image

In light mode it is easier to see. However, the fact that it is highlighted with gray feels like that is the part that we are supposed to pay less attention instead of more. It feels as if it was a deactivated button.

Image

This is what hightlighted code looks like in dark mode in Github, for reference:

Image

And light mode:

Image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aidankmcalister aidankmcalister

Labels
docs Documentation creation, updates or corrections
Projects
None yet
Milestone
No milestone
2 participants
@adriancuadrado @aidankmcalister