Skip to content
This repository was archived by the owner on Jul 5, 2024. It is now read-only.

[Integration Tests] Panic Option::unwrap() on a None value' due to eth_block.withdrawals==None #1687

Closed
AronisAt79 opened this issue Nov 23, 2023 · 1 comment
Assignees
Labels
T-bug Type: bug

Comments

@AronisAt79
Copy link
Contributor

AronisAt79 commented Nov 23, 2023

What command(s) is the bug in?

No response

Describe the bug

Integration Tests have been failing since introduction of #1369, due to Option::Unwrap on None value, when eth_block.withdrawals==None.

https://github.com/privacy-scaling-explorations/zkevm-circuits/actions/runs/6942012340/job/18884044464

@AronisAt79 AronisAt79 added the T-bug Type: bug label Nov 23, 2023
@AronisAt79 AronisAt79 self-assigned this Nov 23, 2023
github-merge-queue bot pushed a commit that referenced this issue Nov 27, 2023
…-4896 withdrawals==None (#1688)

### Description

Integration Tests have been failing since introduction of
#1369,
due to Option::Unwrap on None value, when eth_block.withdrawals==None.

### Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] This change requires a documentation update

### Contents

- zkevm-circuits/zkevm-circuits/src/witness/block.rs

### Rationale
replace eth_block.withdrawals.clone().unwrap() with
eth_block.withdrawals.clone().unwrap_or_default()

### How Has This Been Tested?

https://github.com/privacy-scaling-explorations/zkevm-circuits/actions/runs/6968928576/job/18963801769
<hr>

### Issue

#1687
@AronisAt79
Copy link
Contributor Author

Fixed with #1688

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T-bug Type: bug
Projects
None yet
Development

No branches or pull requests

1 participant