Skip to content

Move the markup sanitization logic to its own component #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stasm opened this issue May 18, 2018 · 1 comment
Open

Move the markup sanitization logic to its own component #202

stasm opened this issue May 18, 2018 · 1 comment
Labels
fluent-react

Comments

@stasm
Copy link
Contributor

stasm commented May 18, 2018

We could simplify <Localized> and separate concerns nicely by moving the markup sanitization logic out of it into a new component.
@piatra piatra mentioned this issue May 22, 2018
Merged
@stasm stasm mentioned this issue May 29, 2018
Open
@stasm
Copy link
Contributor Author

stasm commented May 29, 2018

I have a WIP PR in #211 which works, but unfortunately Enzyme doesn't like this change for some reason and all tests fail. I expected wrapper.contains to just work but I was wrong. Any help will be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fluent-react
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stasm