Skip to content

Commit f6b9da4

Browse files
fix: allow plus signs in ppa
From Launchpad: > At least one lowercase letter or number, followed by letters, numbers, > dots, hyphens or pluses. Keep this name short; it is used in URLs.
1 parent d172e85 commit f6b9da4

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

manifests/ppa.pp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
}
4141

4242
# Validate the resource name
43-
if $name !~ /^ppa:([a-zA-Z0-9\-_.]+)\/([a-zA-z0-9\-_\.]+)$/ {
43+
if $name !~ /^ppa:([a-zA-Z0-9\-_.+]+)\/([a-zA-z0-9\-_.+]+)$/ {
4444
fail("Invalid PPA name: ${name}")
4545
}
4646

spec/defines/ppa_spec.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ def ppa_exec_params(user, repo, distro = 'trusty', environment = [])
5050
'ppa:foo/bar1.0',
5151
'ppa:foo10/bar10',
5252
'ppa:foo-/bar_',
53+
'ppa:foo/bar+',
54+
'ppa:foo+/bar',
5355
].each do |value|
5456
describe 'valid resource names' do
5557
let :facts do

0 commit comments

Comments
 (0)