Skip to content

Commit 9baab9d

Browse files
Fix node-streams dep; prep next release (#43)
* Update node-streams to v7.0.0 * Update changelog * Fix tests * Fix unused variable * Fix copy-paste mistake
1 parent d092a01 commit 9baab9d

File tree

3 files changed

+12
-14
lines changed

3 files changed

+12
-14
lines changed

CHANGELOG.md

+3-5
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,14 @@ Bugfixes:
1212

1313
Other improvements:
1414

15-
## [v7.0.0](https://github.com/purescript-node/purescript-node-http/releases/tag/v7.0.0) - 2022-04-28
15+
## [v8.0.0](https://github.com/purescript-node/purescript-node-http/releases/tag/v8.0.0) - 2022-04-29
1616

1717
Breaking changes:
1818
- Update project and deps to PureScript v0.15.0 (#41 by @JordanMartinez, @sigma-andex)
1919

20-
New features:
21-
22-
Bugfixes:
20+
## [v7.0.0](https://github.com/purescript-node/purescript-node-http/releases/tag/v7.0.0) - 2022-04-28
2321

24-
Other improvements:
22+
Due to implementing a breaking change incorrectly, use v8.0.0 instead.
2523

2624
## [v6.0.0](https://github.com/purescript-node/purescript-node-http/releases/tag/v6.0.0) - 2021-02-26
2725

bower.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@
2222
"purescript-foreign-object": "^4.0.0",
2323
"purescript-maybe": "^6.0.0",
2424
"purescript-node-buffer": "^8.0.0",
25-
"purescript-node-net": "^3.0.0",
26-
"purescript-node-streams": "^6.0.0",
25+
"purescript-node-net": "^4.0.0",
26+
"purescript-node-streams": "^7.0.0",
2727
"purescript-node-url": "^6.0.0",
2828
"purescript-nullable": "^6.0.0",
2929
"purescript-options": "^7.0.0",

test/Main.purs

+7-7
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ respond req res = do
4444
]
4545
setHeader res "Content-Type" "text/html"
4646
_ <- writeString outputStream UTF8 html mempty
47-
end outputStream (pure unit)
47+
end outputStream (const $ pure unit)
4848
"POST" -> void $ pipe inputStream outputStream
4949
_ -> unsafeCrashWith "Unexpected HTTP method"
5050

@@ -139,13 +139,13 @@ simpleReq :: String -> Effect Unit
139139
simpleReq uri = do
140140
log ("GET " <> uri <> ":")
141141
req <- Client.requestFromURI uri logResponse
142-
end (Client.requestAsStream req) (pure unit)
142+
end (Client.requestAsStream req) (const $ pure unit)
143143

144144
complexReq :: Options Client.RequestOptions -> Effect Unit
145145
complexReq opts = do
146146
log $ optsR.method <> " " <> optsR.protocol <> "//" <> optsR.hostname <> ":" <> optsR.port <> optsR.path <> ":"
147147
req <- Client.request opts logResponse
148-
end (Client.requestAsStream req) (pure unit)
148+
end (Client.requestAsStream req) (const $ pure unit)
149149
where
150150
optsR = unsafeCoerce $ options opts
151151

@@ -168,7 +168,7 @@ testUpgrade = do
168168
log "Listening on port 3000."
169169
sendRequests
170170
where
171-
handleUpgrade req socket buffer = do
171+
handleUpgrade req socket _ = do
172172
let upgradeHeader = fromMaybe "" $ lookup "upgrade" $ requestHeaders req
173173
if upgradeHeader == "websocket" then
174174
void $ Socket.writeString
@@ -190,7 +190,7 @@ testUpgrade = do
190190
unsafeCrashWith "Unexpected response to simple request on `testUpgrade`"
191191
else
192192
pure unit
193-
end (Client.requestAsStream reqSimple) (pure unit)
193+
end (Client.requestAsStream reqSimple) (const $ pure unit)
194194
{-
195195
These two requests test that the upgrade callback is called and that it has
196196
access to the original request and can write to the underlying TCP socket
@@ -206,7 +206,7 @@ testUpgrade = do
206206
unsafeCrashWith "Unexpected response to upgrade request on `testUpgrade`"
207207
else
208208
pure unit
209-
end (Client.requestAsStream reqUpgrade) (pure unit)
209+
end (Client.requestAsStream reqUpgrade) (const $ pure unit)
210210

211211
let wsHeaders = Client.RequestHeaders $ fromFoldable
212212
[ Tuple "Connection" "upgrade"
@@ -220,5 +220,5 @@ testUpgrade = do
220220
unsafeCrashWith "Unexpected response to websocket upgrade request on `testUpgrade`"
221221
else
222222
pure unit
223-
end (Client.requestAsStream reqWSUpgrade) (pure unit)
223+
end (Client.requestAsStream reqWSUpgrade) (const $ pure unit)
224224
pure unit

0 commit comments

Comments
 (0)