Skip to content

'arguments-v3' schema improvements #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Viicos opened this issue Mar 13, 2025 · 0 comments
Open

'arguments-v3' schema improvements #1669

Viicos opened this issue Mar 13, 2025 · 0 comments

Comments

@Viicos
Copy link
Member

Viicos commented Mar 13, 2025

Following #1641, some improvements that could be implemented:

  • deduplicate name and lookup_key_collection (comment):

    struct Parameter {
    name: String,
    mode: ParameterMode,
    lookup_key_collection: LookupKeyCollection,

  • Extract potential var_args/var_kwargs parameter (comment):

    positional_args: Vec<Parameter>,
    var_args: Option<Parameter>,
    keyword_only_args: Vec<Parameter>,
    var_kwargs: Option<Parameter>,
  • Extra behavior for extra args, when input is ArgsKwargs. Currently, this is relevant for kwargs (on both schema types), but not for args (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant