Examples

[MAKOMO]

I am trying to run the Advanced Examples from here

https://pymodbus.readthedocs.io/en/latest/source/examples.html#

The linked archive examples.zip seems to be empty while the linked examples.tgz seems to contain the files.

It is adviced to run the examples from within the examples folder, but this does not work for me (macOS/Python.org v3.11).

[Max:/Users/luther/Downloads/examples] ./server_async.py
Traceback (most recent call last):
  File "/Users/luther/Downloads/examples/./server_async.py", line 38, in <module>
    from examples import helper
ModuleNotFoundError: No module named 'examples'

[janiversen]

it's a bug that the zip file is empty.

Last time I tried with the tgz file it worked, but let me check it again.

[janiversen]

"latest" do have a problem ! Funny thing is that when I downloaded from "dev" it worked, but now I only get 168bytes...it is a download problem, because the release contains the right size for both zip and tgz

The problem with "examples" module missing, might be because we test everything within a cloned directory.

Anyhow thanks for reporting the problems I will have a look later to see what can be done.

[janiversen]

Let me put it like this, I am aware of a couple of projects, including this one that uses None implicit....but if you want a change then please make a pull request.

[MAKOMO]

I will try to come up with a pull request for this. One quick question: I see that in the current code the vertical bar is used for union types (eg. in transport/transport.py:get_protocol), a syntax introduced in Python 3.10. Similar tuple is used in type annotations which got introduced in Python 3.9. Is it ok to use this newer typing syntax (instead of the older Tuple and Union, Optional, ... alternatives) despite the target Python version for this lib is still v3.8? I assume those type annotations are ignore anyhow by the Python on run-time and the CI runs mypy on newer Python release, correct?

[janiversen]

Any pull request need to pass CI, which runs linters on all versions, that is something we want to keep.

Changes more or less all declarations to be "x | None" hardly makes sense, it does not make the library more stable. However that is just my opinion as usual pull requests will be reviewed independent of my opinion.

[MAKOMO]

Ok

[alexrudd2]

(for other people reading this later)

Use from __future__ import annotations to permit x | None on Python3.8 (the earliest supported version)

[janiversen]

First part solved, zip now have content. 63324a3

Readthedocs is updated (dev).

[janiversen]

Solved examples as well:
64c182c

Readthedocs will pick it up (dev) in a couple of minutes.