PR feedback

Signed-off-by: Bernát Gábor <[email protected]>

Author: gaborbernat

src/build/__init__.py

@@ -48,7 +48,7 @@ def __init__(self, exception):  # type: (Exception) -> None
         super(BuildBackendException, self).__init__()
         self.exception = exception  # type: Exception
 
-    def __repr__(self):  # type: () -> str
+    def __str__(self):  # type: () -> str
         return 'Backend operation failed: {!r}'.format(self.exception)
 
 

tests/test_env.py

@@ -64,19 +64,15 @@ def test_fail_to_get_script_path(mocker):
 @pytest.mark.skipif(sys.version_info[0] == 2, reason='venv module used on Python 3 only')
 @pytest.mark.skipif(IS_PYPY3, reason='PyPy3 uses get path to create and provision venv')
 def test_fail_to_get_purepath(mocker):
+    mocker.patch.object(build.env, 'virtualenv', None)
     sysconfig_get_path = sysconfig.get_path
-
-    def mock_sysconfig_get_path(path, *args, **kwargs):
-        if path == 'purelib':
-            return ''
-        else:
-            return sysconfig_get_path(path, *args, **kwargs)
-
-    mocker.patch('sysconfig.get_path', side_effect=mock_sysconfig_get_path)
+    mocker.patch(
+        'sysconfig.get_path',
+        side_effect=lambda path, *args, **kwargs: '' if path == 'purelib' else sysconfig_get_path(path, *args, **kwargs),
+    )
 
     with pytest.raises(RuntimeError, match="Couldn't get environment purelib folder"):
-        env = build.env.IsolatedEnvBuilder()
-        with env:
+        with build.env.IsolatedEnvBuilder():
             pass
 
 

tests/test_main.py

@@ -168,4 +168,4 @@ def test_build_raises_build_backend_exception(mocker, test_flit_path):
 
     build.__main__.build_package(test_flit_path, '.', ['sdist'])
 
-    error.assert_called_with('')
+    error.assert_called_with("Backend operation failed: Exception('a')")

tests/test_projectbuilder.py

@@ -414,7 +414,7 @@ def test_prepare_error(mocker, tmp_dir, test_flit_path):
     builder = build.ProjectBuilder(test_flit_path)
     builder._hook.prepare_metadata_for_build_wheel.side_effect = Exception
 
-    with pytest.raises(build.BuildBackendException):
+    with pytest.raises(build.BuildBackendException, match='Backend operation failed: Exception'):
         builder.prepare('wheel', tmp_dir)
 
 
@@ -426,6 +426,5 @@ def test_prepare_not_dir_outdir(mocker, tmp_dir, test_flit_path):
     out = os.path.join(tmp_dir, 'out')
     with open(out, 'w') as f:
         f.write('Not a directory')
-
-    with pytest.raises(build.BuildException):
+    with pytest.raises(build.BuildException, match='Build path .* exists and is not a directory'):
         builder.prepare('wheel', out)