Skip to content

Commit c7173b2

Browse files
committed
Testing if cp35 works for modern C++
1 parent b71f514 commit c7173b2

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

test/10_cpp_standards/cibuildwheel_test.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,12 @@ def test_cpp14():
2525

2626
# VC++ for Python 2.7 does not support modern standards
2727
# The manylinux1 docker image does not have a compiler which supports C++11
28-
# Python 3.4 and 3.5 are compiled with MSVC 10, which does not support C++14
29-
add_env = {'CIBW_SKIP': 'cp27-win* pp27-win32 cp35-win*', 'CIBW_ENVIRONMENT': 'STANDARD=14'}
28+
add_env = {'CIBW_SKIP': 'cp27-win* pp27-win32', 'CIBW_ENVIRONMENT': 'STANDARD=14'}
3029

3130
actual_wheels = utils.cibuildwheel_run(project_dir, add_env=add_env)
3231
expected_wheels = [w for w in utils.expected_wheels('spam', '0.1.0')
3332
if 'cp27-cp27m-win' not in w
34-
and 'pp27-pypy_73-win32' not in w
35-
and 'cp35-cp35m-win' not in w]
33+
and 'pp27-pypy_73-win32' not in w]
3634

3735
assert set(actual_wheels) == set(expected_wheels)
3836

@@ -46,7 +44,7 @@ def test_cpp17():
4644
if os.environ.get('APPVEYOR_BUILD_WORKER_IMAGE', '') == 'Visual Studio 2015':
4745
pytest.skip('Visual Studio 2015 does not support C++17')
4846

49-
add_env = {'CIBW_SKIP': 'cp27-win* pp27-win32 cp35-win* pp36-win32', 'CIBW_ENVIRONMENT': 'STANDARD=17'}
47+
add_env = {'CIBW_SKIP': 'cp27-win* pp27-win32 pp36-win32', 'CIBW_ENVIRONMENT': 'STANDARD=17'}
5048

5149
if utils.platform == 'macos':
5250
add_env['MACOSX_DEPLOYMENT_TARGET'] = '10.13'
@@ -55,7 +53,6 @@ def test_cpp17():
5553
expected_wheels = [w for w in utils.expected_wheels('spam', '0.1.0', macosx_deployment_target='10.13')
5654
if 'cp27-cp27m-win' not in w
5755
and 'pp27-pypy_73-win32' not in w
58-
and 'cp35-cp35m-win' not in w
5956
and 'pp36-pypy36_pp73-win32' not in w]
6057

6158
assert set(actual_wheels) == set(expected_wheels)

0 commit comments

Comments
 (0)