Skip to content

1.2.0 release #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
joerick opened this issue Feb 8, 2020 · 10 comments
Closed
2 tasks done

1.2.0 release #267

joerick opened this issue Feb 8, 2020 · 10 comments

Comments

@joerick
Copy link
Contributor

joerick commented Feb 8, 2020

Hi @YannickJadoul @mayeut,

Just wanted to ask a quick question on the next release - I'm thinking that we've made a lot of progress with cibuildwheel in the last couple months: PRs merged since last release

So I'm thinking it could be time for the 1.2.0 release. At the same time there are some big PRs that seem quite close to release (Pypy #143, Github actions #194, deterministic builds #256) - would you guys like those in 1.2.0 too? There's no need to rush, but if you'd like to get them in, please just shout and I'll hold off on another release until then.

Also logging things I need to remember for the 1.2.0 release:

  • update the examples in /examples to use python3 rather than python
  • update joerick/cibuildwheel-auto-pypi to use python3
@YannickJadoul
Copy link
Member

Yeah, I still need to have a look at the PyPy PR, but if you want, I think we could still get it in. We're closer to finishing it than I thought.

@joerick
Copy link
Contributor Author

joerick commented Feb 9, 2020

Cool, I'll hold off until that's ready.

@YannickJadoul
Copy link
Member

I'll make sure I'll make some time for this, next week, then!

@Czaki
Copy link
Contributor

Czaki commented Feb 20, 2020

See #272 It may block release.

@joerick
Copy link
Contributor Author

joerick commented Mar 2, 2020

Do the virtualenv 20 problems block release, or should we do one with virtualenv pinned to <20? I'd like to get a release out before #256 ideally.

@Czaki
Copy link
Contributor

Czaki commented Mar 2, 2020

Problem is deeper. I create #282 which test if virtualenv is properly used. And it fail with pypy on windows even if virtualenv is forced to be bellow 20 (see #283).

If you want to do release fast I suggest to disable pypy on windows...

@Czaki
Copy link
Contributor

Czaki commented Mar 2, 2020

@joerick I created PR #282 and #283 with different ways to workaround pypy virtualenv problem. Choose which one is better.

Then #256 can be easy merged.

@YannickJadoul
Copy link
Member

@joerick The two original virtualenv issues have been solved and worked around.

I'll have a look at the two PRs soon. Thanks for taking care of this, @Czaki!

@joerick
Copy link
Contributor Author

joerick commented Mar 8, 2020

Released! 4628c13

@joerick joerick closed this as completed Mar 8, 2020
@YannickJadoul
Copy link
Member

Pffffff, I turn my back for a week and I've missed a dozen PRs and a release :-D

Nice work, @Czaki and @joerick ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants