Amend tests' "expect_error" for new default

Author: pradyunsg

tests/functional/test_install.py

@@ -952,7 +952,7 @@ def test_install_nonlocal_compatible_wheel_path(
         '--no-index',
         '--only-binary=:all:',
         Path(data.packages) / 'simplewheel-2.0-py3-fakeabi-fakeplat.whl',
-        expect_error=use_legacy_resolver
+        expect_error=not use_legacy_resolver
     )
     if not use_legacy_resolver:
         assert result.returncode == ERROR
@@ -1467,7 +1467,7 @@ def test_install_editable_with_wrong_egg_name(script, use_legacy_resolver):
     result = script.pip(
         'install', '--editable',
         'file://{pkga_path}#egg=pkgb'.format(**locals()),
-        expect_error=use_legacy_resolver,
+        expect_error=not use_legacy_resolver,
     )
     assert ("Generating metadata for package pkgb produced metadata "
             "for project name pkga. Fix your #egg=pkgb "

tests/functional/test_install_reqs.py

@@ -386,7 +386,7 @@ def test_constraints_constrain_to_local_editable(
         'install', '--no-index', '-f', data.find_links, '-c',
         script.scratch_path / 'constraints.txt', 'singlemodule',
         allow_stderr_warning=True,
-        expect_error=use_legacy_resolver
+        expect_error=not use_legacy_resolver
     )
     if not use_legacy_resolver:
         assert 'Links are not allowed as constraints' in result.stderr
@@ -403,7 +403,7 @@ def test_constraints_constrain_to_local(script, data, use_legacy_resolver):
         'install', '--no-index', '-f', data.find_links, '-c',
         script.scratch_path / 'constraints.txt', 'singlemodule',
         allow_stderr_warning=True,
-        expect_error=use_legacy_resolver
+        expect_error=not use_legacy_resolver
     )
     if not use_legacy_resolver:
         assert 'Links are not allowed as constraints' in result.stderr
@@ -419,7 +419,7 @@ def test_constrained_to_url_install_same_url(script, data, use_legacy_resolver):
         'install', '--no-index', '-f', data.find_links, '-c',
         script.scratch_path / 'constraints.txt', to_install,
         allow_stderr_warning=True,
-        expect_error=use_legacy_resolver
+        expect_error=not use_legacy_resolver
     )
     if not use_legacy_resolver:
         assert 'Links are not allowed as constraints' in result.stderr
@@ -470,7 +470,7 @@ def test_install_with_extras_from_constraints(script, data, use_legacy_resolver)
     result = script.pip_install_local(
         '-c', script.scratch_path / 'constraints.txt', 'LocalExtras',
         allow_stderr_warning=True,
-        expect_error=use_legacy_resolver
+        expect_error=not use_legacy_resolver
     )
     if not use_legacy_resolver:
         assert 'Links are not allowed as constraints' in result.stderr
@@ -502,7 +502,7 @@ def test_install_with_extras_joined(script, data, use_legacy_resolver):
     result = script.pip_install_local(
         '-c', script.scratch_path / 'constraints.txt', 'LocalExtras[baz]',
         allow_stderr_warning=True,
-        expect_error=use_legacy_resolver
+        expect_error=not use_legacy_resolver
     )
     if not use_legacy_resolver:
         assert 'Links are not allowed as constraints' in result.stderr
@@ -519,7 +519,7 @@ def test_install_with_extras_editable_joined(script, data, use_legacy_resolver):
     result = script.pip_install_local(
         '-c', script.scratch_path / 'constraints.txt', 'LocalExtras[baz]',
         allow_stderr_warning=True,
-        expect_error=use_legacy_resolver
+        expect_error=not use_legacy_resolver
     )
     if not use_legacy_resolver:
         assert 'Links are not allowed as constraints' in result.stderr
@@ -558,7 +558,7 @@ def test_install_distribution_union_with_constraints(
     result = script.pip_install_local(
         '-c', script.scratch_path / 'constraints.txt', to_install + '[baz]',
         allow_stderr_warning=True,
-        expect_error=use_legacy_resolver
+        expect_error=not use_legacy_resolver
     )
     if not use_legacy_resolver:
         msg = 'Unnamed requirements are not allowed as constraints'
@@ -578,7 +578,7 @@ def test_install_distribution_union_with_versions(
     result = script.pip_install_local(
         to_install_001 + "[bar]",
         to_install_002 + "[baz]",
-        expect_error=use_legacy_resolver,
+        expect_error=not use_legacy_resolver,
     )
     if not use_legacy_resolver:
         assert (