Remove 'pip search'

Author: hugovk

docs/html/cli/index.md

@@ -31,13 +31,6 @@ pip_wheel
 pip_hash
 ```
 
-```{toctree}
-:maxdepth: 1
-:caption: Package Index information
-
-pip_search
-```
-
 ```{toctree}
 :maxdepth: 1
 :caption: Managing pip itself

docs/html/cli/pip_search.rst

@@ -4,49 +4,4 @@
 pip search
 ==========
 
-
-
-Usage
-=====
-
-.. tab:: Unix/macOS
-
-   .. pip-command-usage:: search "python -m pip"
-
-.. tab:: Windows
-
-   .. pip-command-usage:: search "py -m pip"
-
-
-Description
-===========
-
-.. pip-command-description:: search
-
-
-Options
-=======
-
-.. pip-command-options:: search
-
-
-Examples
-========
-
-#. Search for "peppercorn"
-
-   .. tab:: Unix/macOS
-
-      .. code-block:: console
-
-         $ python -m pip search peppercorn
-         pepperedform    - Helpers for using peppercorn with formprocess.
-         peppercorn      - A library for converting a token stream into [...]
-
-   .. tab:: Windows
-
-      .. code-block:: console
-
-         C:\> py -m pip search peppercorn
-         pepperedform    - Helpers for using peppercorn with formprocess.
-         peppercorn      - A library for converting a token stream into [...]
+The ``pip search`` command has been removed.

docs/html/user_guide.rst

@@ -428,29 +428,6 @@ For more information and examples, see the :ref:`pip list` and :ref:`pip show`
 reference pages.
 
 
-Searching for Packages
-======================
-
-pip can search `PyPI`_ for packages using the ``pip search``
-command:
-
-.. tab:: Unix/macOS
-
-   .. code-block:: shell
-
-      python -m pip search "query"
-
-.. tab:: Windows
-
-   .. code-block:: shell
-
-      py -m pip search "query"
-
-The query will be used to search the names and summaries of all
-packages.
-
-For more information and examples, see the :ref:`pip search` reference.
-
 .. _`Configuration`:
 
 

docs/man/commands/search.rst

@@ -43,9 +43,6 @@ pip-show(1)
 pip-check(1)
     Verify installed packages have compatible dependencies.
 
-pip-search(1)
-    Search PyPI for packages.
-
 pip-wheel(1)
     Build wheels from your requirements.
 

docs/man/index.rst

@@ -0,0 +1 @@
+Remove the ``pip search`` command as it is basically a no-op with PyPI.

news/5216.removal.rst

@@ -66,7 +66,6 @@ markers =
     svn: VCS: Subversion
     mercurial: VCS: Mercurial
     git: VCS: git
-    search: tests for 'pip search'
 
 [coverage:run]
 branch = True

setup.cfg

@@ -58,11 +58,6 @@
         "ConfigurationCommand",
         "Manage local and global configuration.",
     ),
-    "search": CommandInfo(
-        "pip._internal.commands.search",
-        "SearchCommand",
-        "Search PyPI for packages.",
-    ),
     "cache": CommandInfo(
         "pip._internal.commands.cache",
         "CacheCommand",

src/pip/_internal/commands/__init__.py

@@ -3,17 +3,19 @@
 from typing import Any, Iterable, List, Optional, Union
 
 from pip._vendor.packaging.version import LegacyVersion, Version
+from pip._vendor.packaging.version import parse as parse_version
 
 from pip._internal.cli import cmdoptions
 from pip._internal.cli.req_command import IndexGroupCommand
 from pip._internal.cli.status_codes import ERROR, SUCCESS
-from pip._internal.commands.search import print_dist_installation_info
 from pip._internal.exceptions import CommandError, DistributionNotFound, PipError
 from pip._internal.index.collector import LinkCollector
 from pip._internal.index.package_finder import PackageFinder
+from pip._internal.metadata import get_default_environment
 from pip._internal.models.selection_prefs import SelectionPreferences
 from pip._internal.models.target_python import TargetPython
 from pip._internal.network.session import PipSession
+from pip._internal.utils.logging import indent_log
 from pip._internal.utils.misc import write_output
 
 logger = logging.getLogger(__name__)
@@ -137,3 +139,22 @@ def get_available_package_versions(self, options: Values, args: List[Any]) -> No
         write_output("{} ({})".format(query, latest))
         write_output("Available versions: {}".format(", ".join(formatted_versions)))
         print_dist_installation_info(query, latest)
+
+
+def print_dist_installation_info(name: str, latest: str) -> None:
+    env = get_default_environment()
+    dist = env.get_distribution(name)
+    if dist is not None:
+        with indent_log():
+            if dist.version == latest:
+                write_output("INSTALLED: %s (latest)", dist.version)
+            else:
+                write_output("INSTALLED: %s", dist.version)
+                if parse_version(latest).pre:
+                    write_output(
+                        "LATEST:    %s (pre-release; install"
+                        " with `pip install --pre`)",
+                        latest,
+                    )
+                else:
+                    write_output("LATEST:    %s", latest)

src/pip/_internal/commands/index.py

@@ -64,22 +64,13 @@ def pytest_addoption(parser: Parser) -> None:
         default=False,
         help="use venv for virtual environment creation",
     )
-    parser.addoption(
-        "--run-search",
-        action="store_true",
-        default=False,
-        help="run 'pip search' tests",
-    )
 
 
 def pytest_collection_modifyitems(config: Config, items: List[pytest.Item]) -> None:
     for item in items:
         if not hasattr(item, "module"):  # e.g.: DoctestTextfile
             continue
 
-        if item.get_closest_marker("search") and not config.getoption("--run-search"):
-            item.add_marker(pytest.mark.skip("pip search test skipped"))
-
         if "CI" in os.environ:
             # Mark network tests as flaky
             if item.get_closest_marker("network") is not None: