mypy

Author: bmartinn

src/pip/_internal/req/__init__.py

@@ -60,7 +60,8 @@ def install_given_reqs(
         )
 
     # pre allocate installed package names
-    installed = [None] * len(to_install)  # type: List[Any]
+    installed = \
+        [None] * len(to_install)  # type: List[Optional[InstallationResult]]
 
     install_args = [install_options, global_options, args, kwargs]
 
@@ -92,7 +93,7 @@ def install_given_reqs(
 
 def __single_install(
         install_args,      # type: List[Any]
-        a_requirement,     # type: InstallRequirement
+        requirement,       # type: InstallRequirement
         allow_raise=False  # type: bool
 ):
     # type: (...) -> Optional[InstallationResult]
@@ -101,32 +102,32 @@ def __single_install(
 
     (to be called per requirement, either in parallel or serially)
     """
-    if a_requirement.should_reinstall:
-        logger.info('Attempting uninstall: %s', a_requirement.name)
+    if requirement.should_reinstall:
+        logger.info('Attempting uninstall: %s', requirement.name)
         with indent_log():
-            uninstalled_pathset = a_requirement.uninstall(
+            uninstalled_pathset = requirement.uninstall(
                 auto_confirm=True
             )
     try:
-        a_requirement.install(
+        requirement.install(
             install_args[0],   # install_options,
             install_args[1],   # global_options,
             *install_args[2],  # *args,
             **install_args[3]  # **kwargs
         )
     except Exception:
-        should_rollback = (a_requirement.should_reinstall and
-                           not a_requirement.install_succeeded)
+        should_rollback = (requirement.should_reinstall and
+                           not requirement.install_succeeded)
         # if install did not succeed, rollback previous uninstall
         if should_rollback:
             uninstalled_pathset.rollback()
         if allow_raise:
             raise
     else:
-        should_commit = (a_requirement.should_reinstall and
-                         a_requirement.install_succeeded)
+        should_commit = (requirement.should_reinstall and
+                         requirement.install_succeeded)
         if should_commit:
             uninstalled_pathset.commit()
-        return InstallationResult(a_requirement.name)
+        return InstallationResult(requirement.name)
 
     return None