Delay TempDirectory.delete resolution to cleanup

Author: uranusjr

src/pip/_internal/utils/temp_dir.py

@@ -107,13 +107,10 @@ def __init__(
     ):
         super(TempDirectory, self).__init__()
 
-        if path is None and delete is None:
-            # If we were not given an explicit directory, and we were not given
-            # an explicit delete option, then we'll default to deleting unless
-            # the tempdir_registry says otherwise.
+        # If we were given an explicit directory, resolve delete option now.
+        # Otherwise we wait until cleanup and see what tempdir_registry says.
+        if path is not None and delete is None:
             delete = True
-            if _tempdir_registry:
-                delete = _tempdir_registry.get_delete(kind)
 
         if path is None:
             path = self._create(kind)
@@ -145,7 +142,14 @@ def __enter__(self):
 
     def __exit__(self, exc, value, tb):
         # type: (Any, Any, Any) -> None
-        if self.delete:
+        if self.delete is not None:
+            delete = self.delete
+        elif _tempdir_registry:
+            delete = _tempdir_registry.get_delete(self.kind)
+        else:
+            delete = True
+
+        if delete:
             self.cleanup()
 
     def _create(self, kind):