Skip to content

Commit 6081b71

Browse files
committed
Remove InstallRequirement.remove_temporary_source
Since all directories are now globally-managed, we don't need to be concerned with resetting the member values. This will also let us remove several responsibilities from RequirementSet, which will make integrating the new resolver easier.
1 parent ae2d78d commit 6081b71

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

src/pip/_internal/req/req_install.py

-5
Original file line numberDiff line numberDiff line change
@@ -416,11 +416,6 @@ def warn_on_mismatching_name(self):
416416
)
417417
self.req = Requirement(metadata_name)
418418

419-
def remove_temporary_source(self):
420-
# type: () -> None
421-
self.source_dir = None
422-
self._temp_build_dir = None
423-
424419
def check_if_exists(self, use_user_site):
425420
# type: (bool) -> None
426421
"""Find an installed distribution that satisfies or conflicts

src/pip/_internal/req/req_set.py

+1-6
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
from pip._internal import pep425tags
1212
from pip._internal.exceptions import InstallationError
1313
from pip._internal.models.wheel import Wheel
14-
from pip._internal.utils.logging import indent_log
1514
from pip._internal.utils.typing import MYPY_CHECK_RUNNING
1615

1716
if MYPY_CHECK_RUNNING:
@@ -202,8 +201,4 @@ def get_requirement(self, name):
202201

203202
def cleanup_files(self):
204203
# type: () -> None
205-
"""Clean up files, remove builds."""
206-
logger.debug('Cleaning up...')
207-
with indent_log():
208-
for req in self.reqs_to_cleanup:
209-
req.remove_temporary_source()
204+
pass

0 commit comments

Comments
 (0)