pylock: test file name validator

Author: sbidoul

src/pip/_internal/models/pylock.py

@@ -43,7 +43,7 @@ def from_dict(cls, d: Dict[str, Any]) -> Self:
 
 
 def is_valid_pylock_file_name(path: Path) -> bool:
-    return path.name == "pylock.toml" or bool(re.match(PYLOCK_FILE_NAME_RE, path.name))
+    return path.name == "pylock.toml" or bool(PYLOCK_FILE_NAME_RE.match(path.name))
 
 
 def _toml_key(key: str) -> str:

tests/unit/test_pylock.py

@@ -1,3 +1,5 @@
+from pathlib import Path
+
 import pytest
 
 from pip._vendor.packaging.markers import Marker
@@ -10,7 +12,21 @@
     PylockUnsupportedVersionError,
     PylockValidationError,
     _exactly_one,
+    is_valid_pylock_file_name,
+)
+
+
+@pytest.mark.parametrize(
+    "file_name,valid",
+    [
+        ("pylock.toml", True),
+        ("pylock.spam.toml", True),
+        ("pylock.json", False),
+        ("pylock..toml", False),
+    ],
 )
+def test_pylock_file_name(file_name: str, valid: bool) -> None:
+    assert is_valid_pylock_file_name(Path(file_name)) is valid
 
 
 def test_exactly_one() -> None: