Skip to content

Commit 89f235d

Browse files
add a note about further testing the json client
1 parent e5b2fcd commit 89f235d

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

tests/unit/test_collector.py

+6
Original file line numberDiff line numberDiff line change
@@ -459,6 +459,12 @@ def test_parse_links__requires_python(
459459
_test_parse_links_data_attribute(anchor_html, "requires_python", expected)
460460

461461

462+
# TODO: this test generates its own examples to validate the json client implementation
463+
# instead of sharing those examples with the html client testing. We expect this won't
464+
# hide any bugs because operations like resolving PEP 658 metadata should use the same
465+
# code for both types of indices, but it might be nice to explicitly have all our tests
466+
# in test_download.py execute over both html and json indices with
467+
# a pytest.mark.parameterize decorator to ensure nothing slips through the cracks.
462468
def test_parse_links_json() -> None:
463469
json_bytes = json.dumps(
464470
{

0 commit comments

Comments
 (0)