Skip to content

Commit dc99e1a

Browse files
committed
Move Downloader construction to RequirementPreparer.__init__
Just one step away from pulling this out of operations.prepare altogether.
1 parent b479622 commit dc99e1a

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/pip/_internal/operations/prepare.py

+2-6
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ def __init__(
561561
self.src_dir = src_dir
562562
self.build_dir = build_dir
563563
self.req_tracker = req_tracker
564-
self.session = session
564+
self.downloader = Downloader(session, progress_bar)
565565
self.finder = finder
566566

567567
# Where still-packed archives should be written to. If None, they are
@@ -582,8 +582,6 @@ def __init__(
582582
# be combined if we're willing to have non-wheel archives present in
583583
# the wheelhouse output by 'pip wheel'.
584584

585-
self.progress_bar = progress_bar
586-
587585
# Is build isolation allowed?
588586
self.build_isolation = build_isolation
589587

@@ -683,11 +681,9 @@ def prepare_linked_requirement(
683681
# dedicated dir.
684682
download_dir = self.wheel_download_dir
685683

686-
downloader = Downloader(self.session, self.progress_bar)
687-
688684
try:
689685
unpack_url(
690-
link, req.source_dir, downloader, download_dir,
686+
link, req.source_dir, self.downloader, download_dir,
691687
hashes=hashes,
692688
)
693689
except requests.HTTPError as exc:

0 commit comments

Comments
 (0)