Skip to content

Rename InstallRequirement is_direct to user_specified #8242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pfmoore opened this issue May 15, 2020 · 5 comments · Fixed by #8026
Closed

Rename InstallRequirement is_direct to user_specified #8242

pfmoore opened this issue May 15, 2020 · 5 comments · Fixed by #8026
Labels
type: maintenance Related to Development and Maintenance Processes

Comments

@pfmoore
Copy link
Member

pfmoore commented May 15, 2020

What's the problem this feature will solve?
is_direct isn't very informative. The relevant requirements are actually "user specified"

See this comment from @pradyunsg

Describe the solution you'd like
Rename the attribute
@ghost ghost added the S: needs triage Issues/PRs that need to be triaged label May 15, 2020
@pfmoore
Copy link
Member Author

pfmoore commented May 15, 2020

Created this issue as a reminder, as requested 🙂

@pradyunsg pradyunsg added the type: maintenance Related to Development and Maintenance Processes label May 15, 2020
@ghost ghost removed the S: needs triage Issues/PRs that need to be triaged label May 15, 2020
@sbidoul
Copy link
Member

sbidoul commented May 15, 2020

It's done in 6e6f150 as part of #8026

@pfmoore
Copy link
Member Author

pfmoore commented May 15, 2020

Ah, I knew I'd seen this mentioned somewhere else!!! Using Guido's time machine without permission, were you? 🙂

@pradyunsg pradyunsg assigned sbidoul and unassigned pradyunsg May 15, 2020
@pradyunsg
Copy link
Member

Unassigning yourself is allowed only if you assign someone else. 😉

#8026 LGTM, so I'm happy to defer this to @sbidoul. If we want to pull out just the renaming from that PR, and deal with REQUESTED separately (and @sbidoul would prefer someone else to do the grunt-work), I'm happy to do that. :)

@pfmoore pfmoore mentioned this issue May 15, 2020
Merged
1 task
@pfmoore
Copy link
Member Author

pfmoore commented May 15, 2020

I had a "clear assignees" option, so I did that 🙂

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement PEP 376 REQUESTED sbidoul/pip
3 participants
@sbidoul @pfmoore @pradyunsg