From 893400204c9af01e22105449d2772165a0a1bdde Mon Sep 17 00:00:00 2001 From: Pradyun Gedam Date: Thu, 6 Feb 2020 13:57:17 +0530 Subject: [PATCH] Drop unnecessary check in RequirementSet.add_requirement --- src/pip/_internal/req/req_set.py | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/pip/_internal/req/req_set.py b/src/pip/_internal/req/req_set.py index 1312622b87b..bfa6a07c74e 100644 --- a/src/pip/_internal/req/req_set.py +++ b/src/pip/_internal/req/req_set.py @@ -120,6 +120,8 @@ def add_requirement( # Unnamed requirements are scanned again and the requirement won't be # added as a dependency until after scanning. + # TODO: Check if [install_req] is needed, change to [] to check + # Means -> can we depend on unnamed requirements? if not install_req.name: self.add_unnamed_requirement(install_req) return [install_req], None @@ -149,11 +151,6 @@ def add_requirement( # We'd want to rescan this requirement later return [install_req], install_req - # Assume there's no need to scan, and that we've already - # encountered this for scanning. - if install_req.constraint or not existing_req.constraint: - return [], existing_req - does_not_satisfy_constraint = ( install_req.link and not (