Skip to content

Commit e6a76a0

Browse files
committed
Downgrade hyphen and uppercase deprecation warning to info
1 parent 6ead555 commit e6a76a0

File tree

2 files changed

+9
-54
lines changed

2 files changed

+9
-54
lines changed

setuptools/dist.py

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -628,17 +628,16 @@ def _enforce_underscore(self, opt: str, section: str) -> str:
628628

629629
underscore_opt = opt.replace('-', '_')
630630
affected = f"(Affected: {self.metadata.name})." if self.metadata.name else ""
631-
SetuptoolsDeprecationWarning.emit(
631+
InformationOnly.emit(
632632
f"Invalid dash-separated key {opt!r} in {section!r} (setup.cfg), "
633633
f"please use the underscore name {underscore_opt!r} instead.",
634634
f"""
635-
Usage of dash-separated {opt!r} will not be supported in future
636-
versions. Please use the underscore name {underscore_opt!r} instead.
635+
Usage of dash-separated {opt!r} is not supported by Python packaging
636+
specifications. Please use the underscore name {underscore_opt!r} instead.
637637
{affected}
638638
""",
639639
see_docs="userguide/declarative_config.html",
640-
due_date=(2026, 3, 3),
641-
# Warning initially introduced in 3 Mar 2021
640+
# Changed from warning to info after https://github.com/pypa/setuptools/issues/4910
642641
)
643642
return underscore_opt
644643

@@ -648,17 +647,17 @@ def _enforce_option_lowercase(self, opt: str, section: str) -> str:
648647

649648
lowercase_opt = opt.lower()
650649
affected = f"(Affected: {self.metadata.name})." if self.metadata.name else ""
651-
SetuptoolsDeprecationWarning.emit(
650+
InformationOnly.emit(
652651
f"Invalid uppercase key {opt!r} in {section!r} (setup.cfg), "
653652
f"please use lowercase {lowercase_opt!r} instead.",
654653
f"""
655-
Usage of uppercase key {opt!r} in {section!r} will not be supported in
656-
future versions. Please use lowercase {lowercase_opt!r} instead.
654+
Usage of uppercase key {opt!r} in {section!r} is not supported
655+
by Python packaging specifications. Please use lowercase {lowercase_opt!r}
656+
instead.
657657
{affected}
658658
""",
659659
see_docs="userguide/declarative_config.html",
660-
due_date=(2026, 3, 3),
661-
# Warning initially introduced in 6 Mar 2021
660+
# Changed from warning to info after https://github.com/pypa/setuptools/issues/4910
662661
)
663662
return lowercase_opt
664663

setuptools/tests/config/test_setupcfg.py

Lines changed: 0 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import configparser
22
import contextlib
33
import inspect
4-
import re
54
from pathlib import Path
65
from unittest.mock import Mock, patch
76

@@ -421,49 +420,6 @@ def test_not_utf8(self, tmpdir):
421420
with get_dist(tmpdir):
422421
pass
423422

424-
@pytest.mark.parametrize(
425-
("error_msg", "config", "invalid"),
426-
[
427-
(
428-
"Invalid dash-separated key 'author-email' in 'metadata' (setup.cfg)",
429-
DALS(
430-
"""
431-
[metadata]
432-
author-email = [email protected]
433-
maintainer_email = [email protected]
434-
"""
435-
),
436-
{"author-email": "[email protected]"},
437-
),
438-
(
439-
"Invalid uppercase key 'Name' in 'metadata' (setup.cfg)",
440-
DALS(
441-
"""
442-
[metadata]
443-
Name = foo
444-
description = Some description
445-
"""
446-
),
447-
{"Name": "foo"},
448-
),
449-
],
450-
)
451-
def test_invalid_options_previously_deprecated(
452-
self, tmpdir, error_msg, config, invalid
453-
):
454-
# This test and related methods can be removed when no longer needed.
455-
# Deprecation postponed due to push-back from the community in
456-
# https://github.com/pypa/setuptools/issues/4910
457-
fake_env(tmpdir, config)
458-
with pytest.warns(SetuptoolsDeprecationWarning, match=re.escape(error_msg)):
459-
dist = get_dist(tmpdir).__enter__()
460-
461-
tmpdir.join('setup.cfg').remove()
462-
463-
for field, value in invalid.items():
464-
attr = field.replace("-", "_").lower()
465-
assert getattr(dist.metadata, attr) == value
466-
467423

468424
class TestOptions:
469425
def test_basic(self, tmpdir):

0 commit comments

Comments
 (0)