Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Enable automatic pre-commit checks in workflows #4850

Open
1 task done
shenxianpeng opened this issue Feb 22, 2025 · 0 comments · May be fixed by #4851
Open
1 task done

[FR] Enable automatic pre-commit checks in workflows #4850

shenxianpeng opened this issue Feb 22, 2025 · 0 comments · May be fixed by #4851
Labels
enhancement Needs Triage Issues that need to be evaluated for severity and status.

Comments

@shenxianpeng
Copy link
Contributor

What's the problem this feature will solve?

I noticed that setuptools has a .pre-commit-config.yml file in the repository, but it doesn’t seem to be executed in any workflow.

Describe the solution you'd like

Perhaps could integrate pre-commit.ci to run pre-commit checks automatically, ensuring consistency and catching issues early.

Alternative Solutions

add a new [testenv:lint] to tox.ini or add a new step to .github/workflow/main.yml

Additional context

No response

Code of Conduct

  • I agree to follow the PSF Code of Conduct
@shenxianpeng shenxianpeng added enhancement Needs Triage Issues that need to be evaluated for severity and status. labels Feb 22, 2025
@shenxianpeng shenxianpeng linked a pull request Feb 22, 2025 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Needs Triage Issues that need to be evaluated for severity and status.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add ci configuration for .pre-commit-config.yaml shenxianpeng/setuptools
1 participant
@shenxianpeng