Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Pull requests should require at least one second-party approval #4917

Open
mdbernard opened this issue Mar 24, 2025 · 2 comments
Open

[CI] Pull requests should require at least one second-party approval #4917

mdbernard opened this issue Mar 24, 2025 · 2 comments
Labels
Needs Discussion Issues where the implementation still needs to be discussed. proposal question

Comments

@mdbernard
Copy link

mdbernard commented Mar 24, 2025 •
edited
Loading

Second-party review and approval should be required on all pull requests.
@ianballard
Copy link

Please see this open issue Urgent: Governance and Change Management Review After Breaking Change in #4870

@webknjaz
Copy link
Member

While this might work for some project, with the amount of maintainers capable of being active in here, it would likely block any progress for months if not more. I don't think that such a request is realistic where there's not at least 3 consistently active maintainers.

@webknjaz webknjaz added question proposal Needs Discussion Issues where the implementation still needs to be discussed. labels Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs Discussion Issues where the implementation still needs to be discussed. proposal question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@webknjaz @ianballard @mdbernard