Merge pull request #59 from jakkdl/105_await_nursery_start

fixes #56

Author: Zac-HD

CHANGELOG.md

@@ -1,6 +1,9 @@
 # Changelog
 *[CalVer, YY.month.patch](https://calver.org/)*
 
+## 22.11.2
+- TRIO105 now also checks that you `await`ed `nursery.start()`.
+
 ## 22.11.1
 - TRIO102 is no longer skipped in (async) context managers, since it's not a missing-checkpoint warning.
 

flake8_trio.py

@@ -29,7 +29,7 @@
 from flake8.options.manager import OptionManager
 
 # CalVer: YY.month.patch, e.g. first release of July 2022 == "22.7.1"
-__version__ = "22.11.1"
+__version__ = "22.11.2"
 
 
 Error_codes = {
@@ -785,7 +785,7 @@ def iter_guaranteed_once(iterable: ast.expr) -> bool:
     return False
 
 
-trio_async_functions = (
+trio_async_funcs = (
     "aclose_forcefully",
     "open_file",
     "open_ssl_over_tcp_listeners",
@@ -806,6 +806,7 @@ def iter_guaranteed_once(iterable: ast.expr) -> bool:
 class Visitor105(Flake8TrioVisitor):
     def __init__(self, *args: Any, **kwargs: Any):
         super().__init__(*args, **kwargs)
+        # keep a node stack so we can check whether calls are awaited
         self.node_stack: List[ast.AST] = []
 
     def visit(self, node: ast.AST):
@@ -817,8 +818,10 @@ def visit_Call(self, node: ast.Call):
         if (
             isinstance(node.func, ast.Attribute)
             and isinstance(node.func.value, ast.Name)
-            and node.func.value.id == "trio"
-            and node.func.attr in trio_async_functions
+            and (
+                (node.func.value.id == "trio" and node.func.attr in trio_async_funcs)
+                or (node.func.value.id == "nursery" and node.func.attr == "start")
+            )
             and (
                 len(self.node_stack) < 2
                 or not isinstance(self.node_stack[-2], ast.Await)

tests/trio105.py

@@ -48,3 +48,12 @@ async def foo():
     # it isn't supported
     k = trio.open_file()  # error: 8, "open_file"
     await k
+
+    # issue #56
+    nursery = trio.open_nursery()
+    await nursery.start()
+    await nursery.start_foo()
+
+    nursery.start()  # error: 4, "start"
+    nursery.start_soon()
+    nursery.start_foo()