-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
Deprecate old backward compatible shims in configure_formatter()/handler(). #115032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
cc @vsajip |
I realise Django doesn't use them any more, but what about other code / users? I wouldn't strongly object to removing them, but there's a chance that any such change might need to be reverted if there are complaints that it breaks existing code somewhere. And, of course, no backporting of any such change. Perhaps deprecate, but not remove immediately - rather, in line with the usual deprecation cycle. It's just a little wart in the current code, after all. |
Yes that's what I was trying to propose. We have an existing and straightforward upgrade path i.e. use
True, but they become an issue when there are dozens of such workarounds ("death by a thousand cuts"). |
Well, it's not that bad IMO, but I'll look at a PR that does deprecation. |
While preparing a patch, I noticed that we can deprecate |
…t about `fmt` retry.
…t about `fmt` retry. (pythonGH-115303)
Feature or enhancement
Proposal:
DictConfigurator.configure_formatter()
andconfigure_handler()
contain workarounds for old configurationscpython/Lib/logging/config.py
Lines 670 to 676 in bcccf1f
cpython/Lib/logging/config.py
Lines 844 to 851 in bcccf1f
Django doesn't use
fmt
andstrm
for many years. I think both can be deprecated and removed.I'd like to prepare a patch, if accepted.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Linked PRs
fmt
retry. #115303The text was updated successfully, but these errors were encountered: