Skip to content

Add workaround for pip 6434 issue (pip v19.1) - [merged] #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaraco opened this issue Oct 22, 2020 · 7 comments
Closed

Add workaround for pip 6434 issue (pip v19.1) - [merged] #183

jaraco opened this issue Oct 22, 2020 · 7 comments

Comments

@jaraco
Copy link
Member

jaraco commented Oct 22, 2020

In GitLab by @gahjelle on May 6, 2019, 18:30

Merges pip-19_1-issue -> master

Fixes #54

Pin pip at version less than 19.1

Full discussion at https://discuss.python.org/t/pip-19-1-and-installing-in-editable-mode-with-pyproject-toml/1553

One liner copied from https://github.com/ansible/molecule/pull/2009/files

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @gahjelle on May 6, 2019, 18:46

added 3 commits

Compare with previous version

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @gahjelle on May 6, 2019, 19:05

added 1 commit

Compare with previous version

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @codecov on May 6, 2019, 19:22

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #54   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         220    220           
  Branches       22     22           
=====================================
  Hits          220    220

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e2724e...5fec7b3. Read the comment docs.

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on May 6, 2019, 19:27

approved this merge request

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on May 6, 2019, 19:28

merged

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on May 6, 2019, 19:28

mentioned in commit 9bc7130

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on May 6, 2019, 19:29

Woo-hoo. Thanks also for fixing the codecov bug in 5fec7b3, following up on !52.

@jaraco jaraco closed this as completed Oct 22, 2020
jaraco added a commit that referenced this issue Dec 21, 2023
Implement a low-level interface for loaders to implement instead of TraversableResources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant