Skip to content

Commit 19c12c6

Browse files
authoredApr 11, 2025
Remove unused lines in build_android_library.sh (#10088)
For CI, check out recursively.
1 parent ac80032 commit 19c12c6

File tree

4 files changed

+3
-8
lines changed

4 files changed

+3
-8
lines changed
 

‎.github/workflows/_android.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
with:
1515
runner: linux.2xlarge
1616
docker-image: executorch-ubuntu-22.04-clang12-android
17-
submodules: 'true'
17+
submodules: 'recursive'
1818
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
1919
timeout: 90
2020
upload-artifact: android-apps

‎.github/workflows/android-perf.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ jobs:
345345
with:
346346
runner: linux.2xlarge
347347
docker-image: executorch-ubuntu-22.04-clang12-android
348-
submodules: 'true'
348+
submodules: 'recursive'
349349
ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
350350
timeout: 90
351351
upload-artifact: android-apps

‎.github/workflows/android-release-artifacts.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
secrets-env: EXECUTORCH_MAVEN_SIGNING_KEYID EXECUTORCH_MAVEN_SIGNING_PASSWORD EXECUTORCH_MAVEN_CENTRAL_PASSWORD EXECUTORCH_MAVEN_CENTRAL_USERNAME EXECUTORCH_MAVEN_SIGNING_GPG_KEY_CONTENTS
4646
runner: linux.2xlarge
4747
docker-image: executorch-ubuntu-22.04-clang12-android
48-
submodules: 'true'
48+
submodules: 'recursive'
4949
ref: ${{ github.sha }}
5050
timeout: 90
5151
upload-artifact: android-apps

‎scripts/build_android_library.sh

-5
Original file line numberDiff line numberDiff line change
@@ -65,11 +65,6 @@ build_android_native_library() {
6565
fi
6666
cmake --build "${CMAKE_OUT}" -j "${CMAKE_JOBS}" --target install --config "${EXECUTORCH_CMAKE_BUILD_TYPE}"
6767

68-
# Update tokenizers submodule
69-
pushd extension/llm/tokenizers
70-
echo "Update tokenizers submodule"
71-
git submodule update --init
72-
popd
7368
cmake extension/android \
7469
-DCMAKE_TOOLCHAIN_FILE=${ANDROID_NDK}/build/cmake/android.toolchain.cmake \
7570
-DANDROID_ABI="${ANDROID_ABI}" \

0 commit comments

Comments
 (0)