Skip to content

Commit bcce29e

Browse files
committed
fix(app-vite): pin workbox-build to 7.0.x
instead of ^7.0.0, see GoogleChrome/workbox#3357
1 parent 56d5a0a commit bcce29e

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

Diff for: app-vite/lib/modes/pwa/pwa-installation.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ const nodePackager = require('../../helpers/node-packager')
77
const hasTypescript = require('../../helpers/has-typescript')
88
const { hasEslint } = require('../../helpers/has-eslint')
99

10-
const defaultVersion = '^7.0.0'
10+
// https://github.com/GoogleChrome/workbox/issues/3357
11+
// 7.0.0 is the only current working version, but using 7.0.x in hopes of future updates
12+
const defaultVersion = '7.0.x'
1113

1214
const pwaDeps = {
1315
'workbox-core': defaultVersion,

Diff for: app-vite/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
"vue": "^3.0.0",
9797
"vue-router": "^4.0.0",
9898
"vuex": "^4.0.0",
99-
"workbox-build": "^7.0.0"
99+
"workbox-build": "7.0.x"
100100
},
101101
"peerDependencies": {
102102
"@electron/packager": ">= 18",
@@ -108,7 +108,7 @@
108108
"vue": "^3.2.29",
109109
"vue-router": "^4.0.12",
110110
"vuex": "^4.0.0",
111-
"workbox-build": ">= 6"
111+
"workbox-build": "^6 || 7.0.x"
112112
},
113113
"peerDependenciesMeta": {
114114
"electron-builder": {

0 commit comments

Comments
 (0)