Skip to content

Updating doc mapping does not update index V2 validation #5738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rdettai opened this issue Apr 8, 2025 · 2 comments
Open

Updating doc mapping does not update index V2 validation #5738

rdettai opened this issue Apr 8, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@rdettai
Copy link
Collaborator

rdettai commented Apr 8, 2025

Describe the bug
We can update a doc mapping with PUT api/v1/indexes/<index id>, indexing pipelines are automatically restarted, but when we hit the ingest V2 endpoint after the update, documents obeying the new doc mapping are likely be considered as invalid by existing shards that still use the previous doc mapping.

Steps to reproduce (if applicable)
Test was added in https://github.com/quickwit-oss/quickwit/pull/5739/files

Expected behavior
The best solution is likely to force the recreation of all shards for the existing index

@rdettai rdettai added the bug Something isn't working label Apr 8, 2025
@trinity-1686a
Copy link
Contributor

do you happen to know when does the issue resolve by itself? Is that on node restart, or possibly when ingesting plan or something like that evolves?

@rdettai
Copy link
Collaborator Author

rdettai commented Apr 8, 2025

If my understanding is correct, it resolves fully when all shards existing before the doc mapping update are closed.

  • On a graceful shutdown, I expect a node to close all its shards. I don't think a shard can be re-opened.
  • If the graceful shutdown fail, I don't know what happens. I don't know if existing shards can be resumed.

The in-between state where some shards are accepting some docs and others not is tricky...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants