From 156f9be28597692b7a00bbc608b3c3c0c3833edf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kirill=20M=C3=BCller?= Date: Mon, 8 Mar 2021 09:59:59 +0100 Subject: [PATCH 1/2] Crude caching of in-out --- R/transform-files.R | 11 +++++++---- R/utils-cache.R | 29 ++++++++++++++++++++++------- 2 files changed, 29 insertions(+), 11 deletions(-) diff --git a/R/transform-files.R b/R/transform-files.R index f887391e9..e4adca537 100644 --- a/R/transform-files.R +++ b/R/transform-files.R @@ -99,6 +99,10 @@ make_transformer <- function(transformers, base_indention = base_indention ) ) + + if (!is.null(attr(use_cache, "text"))) { + text <- attr(use_cache, "text") + } } else { use_cache <- FALSE } @@ -117,10 +121,9 @@ make_transformer <- function(transformers, ~. ) if (should_use_cache) { - cache_write( - transformed_code, transformers, - cache_more_specs(include_roxygen_examples, base_indention) - ) + specs <- cache_more_specs(include_roxygen_examples, base_indention) + cache_write(transformed_code, transformers, specs) + cache_write(text, transformers, specs, transformed_code) } transformed_code } else { diff --git a/R/utils-cache.R b/R/utils-cache.R index 1c8845a54..8ffb55ff2 100644 --- a/R/utils-cache.R +++ b/R/utils-cache.R @@ -25,11 +25,21 @@ is_cached <- function(text, transformers, more_specs, cache_dir = cache_dir_default()) { - R.cache::generateCache( + cache_path <- R.cache::generateCache( key = cache_make_key(text, transformers, more_specs), dirs = cache_dir - ) %>% - file.exists() + ) + + if (!file.exists(cache_path)) { + return(FALSE) + } + + text <- readLines(cache_path) + if (length(text) > 0) { + structure(TRUE, text = text) + } else { + TRUE + } } @@ -164,12 +174,17 @@ cache_by_expression <- function(text, #' #' @inheritParams cache_make_key #' @keywords internal -cache_write <- function(text, transformers, more_specs) { - R.cache::generateCache( +cache_write <- function(text, transformers, more_specs, text_out = NULL) { + cache_path <- R.cache::generateCache( key = cache_make_key(text, transformers, more_specs), dirs = cache_dir_default() - ) %>% - file.create() + ) + + if (is.null(text_out)) { + file.create(cache_path) + } else { + writeLines(text_out, cache_path) + } } styler_version <- unlist(unname(read.dcf("DESCRIPTION")[, "Version"])) From 70ba54ab8ae3f682b733f86878b51120c898b45b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kirill=20M=C3=BCller?= Date: Sat, 27 Mar 2021 06:45:17 +0100 Subject: [PATCH 2/2] URL --- _pkgdown.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_pkgdown.yml b/_pkgdown.yml index 8845bb940..2cf84d5f5 100644 --- a/_pkgdown.yml +++ b/_pkgdown.yml @@ -44,7 +44,7 @@ template: authors: Kirill Müller: - href: http://krlmlr.info + href: https://krlmlr.info Lorenz Walthert: href: http://lorenzwalthert.netlify.com