Doc blocks and simplify return thanks to @Tornhoof

Author: lukebakken

projects/RabbitMQ.Client/client/api/IChannel.cs

@@ -408,14 +408,6 @@ ValueTask BasicPublishAsync<TProperties>(CachedString exchange, CachedString rou
         /// </summary>
         void ExchangeDelete(string exchange, bool ifUnused);
 
-        /*
-         * TODO LRB rabbitmq/rabbitmq-dotnet-client#1347
-        /// <summary>
-        /// Asynchronously delete an exchange.
-        /// </summary>
-        ValueTask ExchangeDeleteAsync(string exchange, bool ifUnused);
-        */
-
         /// <summary>
         /// Asynchronously delete an exchange.
         /// </summary>
@@ -455,20 +447,24 @@ ValueTask BasicPublishAsync<TProperties>(CachedString exchange, CachedString rou
         /// <summary>
         /// Bind a queue to an exchange.
         /// </summary>
+        /// <param name="queue">The queue.</param>
+        /// <param name="exchange">The exchange.</param>
+        /// <param name="routingKey">The routing key.</param>
+        /// <param name="arguments">The arguments.</param>
         /// <remarks>
-        ///   <para>
-        ///     Routing key must be shorter than 255 bytes.
-        ///   </para>
+        /// Routing key must be shorter than 255 bytes.
         /// </remarks>
         void QueueBind(string queue, string exchange, string routingKey, IDictionary<string, object> arguments);
 
         /// <summary>
         /// Asynchronously bind a queue to an exchange.
         /// </summary>
+        /// <param name="queue">The queue.</param>
+        /// <param name="exchange">The exchange.</param>
+        /// <param name="routingKey">The routing key.</param>
+        /// <param name="arguments">The arguments.</param>
         /// <remarks>
-        ///   <para>
-        ///     Routing key must be shorter than 255 bytes.
-        ///   </para>
+        /// Routing key must be shorter than 255 bytes.
         /// </remarks>
         ValueTask QueueBindAsync(string queue, string exchange, string routingKey, IDictionary<string, object> arguments);
 

projects/RabbitMQ.Client/client/impl/RecoveryAwareChannel.cs

@@ -81,11 +81,7 @@ public override ValueTask BasicAckAsync(ulong deliveryTag, bool multiple)
             }
             else
             {
-#if NET6_0_OR_GREATER
-                return ValueTask.CompletedTask;
-#else
-                return new ValueTask(Task.CompletedTask);
-#endif
+                return default;
             }
         }
 
@@ -107,11 +103,7 @@ public override ValueTask BasicNackAsync(ulong deliveryTag, bool multiple, bool
             }
             else
             {
-#if NET6_0_OR_GREATER
-                return ValueTask.CompletedTask;
-#else
-                return new ValueTask(Task.CompletedTask);
-#endif
+                return default;
             }
         }
 
@@ -133,11 +125,7 @@ public override ValueTask BasicRejectAsync(ulong deliveryTag, bool requeue)
             }
             else
             {
-#if NET6_0_OR_GREATER
-                return ValueTask.CompletedTask;
-#else
-                return new ValueTask(Task.CompletedTask);
-#endif
+                return default;
             }
         }
     }

projects/RabbitMQ.Client/client/impl/SocketFrameHandler.cs

@@ -282,11 +282,7 @@ public ValueTask WriteAsync(ReadOnlyMemory<byte> memory)
         {
             if (_closed)
             {
-#if NET6_0_OR_GREATER
-                return ValueTask.CompletedTask;
-#else
-                return new ValueTask(Task.CompletedTask);
-#endif
+                return default;
             }
 
             return _channelWriter.WriteAsync(memory);