add syncheck:unused-binder and use it to rename (and, bonus, get the bright green highlight thingy) binders with no references

closes #629
closes #196

Author: rfindler

drracket-tool-doc/scribblings/drracket-tools/drracket-tools.scrbl

@@ -450,7 +450,18 @@ in order to make the results be platform independent.
 
   @history[#:added "1.2"]
   }
-                                                      
+
+ @defmethod[(syncheck:unused-binder [source-obj (not/c #f)]
+                                    [left exact-nonnegative-integer?]
+                                    [right exact-nonnegative-integer?])
+            void?]{
+  Called to indicate that there is a binder with no
+  references in @racket[source-obj] at the location spanned by
+  @racket[left] and @racket[right].
+
+  @history[#:added "1.4"]
+}
+
  @defmethod[(syncheck:color-range [source-obj (not/c #f)]
                                   [start exact-nonnegative-integer?]
                                   [end exact-nonnegative-integer?]
@@ -558,6 +569,7 @@ in order to make the results be platform independent.
                     syncheck:add-jump-to-definition/phase-level+space
                     syncheck:add-definition-target
                     syncheck:add-definition-target/phase-level+space
+                    syncheck:unused-binder
                     syncheck:add-id-set 
                     syncheck:color-range
                     syncheck:add-prefixed-require-reference

drracket-tool-test/tests/check-syntax/syncheck-direct.rkt

@@ -767,6 +767,10 @@
   (and (equal? type 'unused-identifier)
        (list start end)))
 
+(define-get-arrows unused-binder
+  (syncheck:unused-binder _ start end)
+  (list start end))
+
 (check-equal?
  (get-text-type
   (string-append
@@ -794,7 +798,24 @@
               (set '(69 74)           ;racket/match from multi-in
                    '(77 87)))         ;racket/set
 
+(check-equal?
+ (unused-binder
+  (string-append
+   "#lang racket/base\n"
+   "(define unused 1)\n"))
+ (set '(26 32)))
 
+(check-equal?
+ (unused-binder
+  (string-append
+   "#lang racket/base\n"
+   "(define-syntax-rule (m f)\n"
+   "  (void\n"
+   "   (let ([f 1]) f)\n"
+   "   (let ([f 2]) f)))\n"
+   "\n"
+   "(m ffff)"))
+ (set '(96 100)))
 
 
 ;                                                                                                             

drracket-tool-text-lib/drracket/check-syntax.rkt

@@ -52,6 +52,7 @@
  syncheck:add-jump-to-definition/phase-level+space
  syncheck:add-definition-target
  syncheck:add-definition-target/phase-level+space
+ syncheck:unused-binder
  syncheck:add-prefixed-require-reference
  syncheck:add-unused-require
  syncheck:color-range)

drracket-tool-text-lib/drracket/private/syncheck/syncheck-intf.rkt

@@ -19,6 +19,7 @@
     syncheck:add-jump-to-definition/phase-level+space
     syncheck:add-definition-target
     syncheck:add-definition-target/phase-level+space
+    syncheck:unused-binder
     syncheck:add-prefixed-require-reference
     syncheck:add-unused-require
     syncheck:color-range
@@ -74,6 +75,7 @@
     (define/public (syncheck:add-definition-target source pos-left pos-right id mods) (void))
     (define/public (syncheck:add-definition-target/phase-level+space source pos-left pos-right id mods phase-level+space)
       (syncheck:add-definition-target source pos-left pos-right id mods))
+    (define/public (syncheck:unused-binder source pos-left pos-right) (void))
     (define/public (syncheck:color-range source start finish style-name) (void))
     (define/public (syncheck:add-prefixed-require-reference
                     req-src req-pos-left req-pos-right

drracket-tool-text-lib/drracket/private/syncheck/syncheck-local-member-names.rkt

@@ -20,5 +20,6 @@
   syncheck:add-jump-to-definition/phase-level+space
   syncheck:add-definition-target
   syncheck:add-definition-target/phase-level+space
+  syncheck:unused-binder
   syncheck:add-prefixed-require-reference
   syncheck:add-unused-require)

drracket-tool-text-lib/drracket/private/syncheck/traversals.rkt

@@ -1129,6 +1129,11 @@
       (define end (second val))
       (define color? (third val))
       (define (show-starts)
+        (when (zero? start)
+          (define defs-text (current-annotations))
+          (when defs-text
+            (send defs-text syncheck:unused-binder
+                  (list-ref key 0) (list-ref key 1) (list-ref key 2))))
         (add-mouse-over/loc (list-ref key 0) (list-ref key 1) (list-ref key 2)
                             (cond
                               [(zero? start)
@@ -1624,6 +1629,7 @@
     (log syncheck:add-prefixed-require-reference
          _req-src req-pos-left req-pos-right
          prefix _prefix-src prefix-start prefix-end)
+    (log syncheck:unused-binder _src left right)
     (log syncheck:add-unused-require _req-src req-pos-left req-pos-right)
 
     (define/public (get-trace) (reverse trace))

drracket-tool-text-lib/info.rkt

@@ -13,7 +13,7 @@
 
 (define pkg-authors '(robby))
 
-(define version "1.3")
+(define version "1.4")
 
 (define license
   '(Apache-2.0 OR MIT))