Add should fail if param not found logic (#45)

* Return error is param is not found to fail deployment

* create test

* ltrace is not installing

* add workflow_dispatch to gha

* Revert "ltrace is not installing"

This reverts commit f52b02b.

* fix broken cargo test

* revmoe some deprications

* remove nightly install

* use default stable rustup

* lint error

Author: jeremiahlukus

.devcontainer/Dockerfile

@@ -1,13 +1,19 @@
-FROM mcr.microsoft.com/vscode/devcontainers/rust:0.202.9-bullseye
+FROM mcr.microsoft.com/devcontainers/rust:1-1-bullseye
+
+RUN sudo apt-get update -y \
+    && sudo apt-get upgrade -y 
+
+RUN sudo apt-get install -y --fix-missing zip 
 
 RUN sudo apt-get update -y \
     && sudo apt-get upgrade -y \
     && sudo apt-get install -y zip ltrace
 
-RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain nightly
+RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
 RUN rustup update \
     && rustup target add aarch64-unknown-linux-gnu
 
+RUN rustup default stable
 # x86_64 to arm64 support.
 RUN sudo apt-get install -y \
     qemu \

.github/workflows/test.yml

@@ -1,5 +1,5 @@
 name: Test
-on: [push]
+on: [push, workflow_dispatch]
 jobs:
   image:
     name: Image

Cargo.toml

@@ -8,7 +8,7 @@ name = "crypteia"
 
 [lib]
 name = "crypteia"
-crate_type = ["cdylib"]
+crate-type = ["cdylib"]
 
 [dependencies]
 # bin

amzn/Dockerfile

@@ -1,10 +1,11 @@
 FROM public.ecr.aws/sam/build-nodejs18.x
 
-RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain nightly
+RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
 ENV PATH="~/.cargo/bin:${PATH}"
 
 RUN ~/.cargo/bin/rustup update \
     && ~/.cargo/bin/rustup target add aarch64-unknown-linux-gnu
 
+RUN rustup default stable
 ENV CRYPTEIA_BUILD_OS=amzn
 ENV CRYPTEIA_BUILD_TARGET=x86_64-unknown-linux-gnu

amzn/Dockerfile-arm64

@@ -1,10 +1,11 @@
 FROM public.ecr.aws/sam/build-nodejs18.x:latest-arm64
 
-RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain nightly
+RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
 ENV PATH="~/.cargo/bin:${PATH}"
 
 RUN ~/.cargo/bin/rustup update \
     && ~/.cargo/bin/rustup target add aarch64-unknown-linux-gnu
 
+RUN rustup default stable
 ENV CRYPTEIA_BUILD_OS=amzn
 ENV CRYPTEIA_BUILD_TARGET=aarch64-unknown-linux-gnu

bin/build-arch

@@ -13,8 +13,7 @@ mkdir -p ./build ./target
 
 cargo build \
   --release \
-  --target "${CRYPTEIA_BUILD_TARGET}" \
-  -Z sparse-registry
+  --target "${CRYPTEIA_BUILD_TARGET}" 
 
 cp "./target/${CRYPTEIA_BUILD_TARGET}/release/crypteia" "./build/${BIN}"
 cp ./target/${CRYPTEIA_BUILD_TARGET}/release/libcrypteia.so "./build/${LIB}"

debian/Dockerfile-arm64

@@ -4,12 +4,12 @@ RUN apt update && apt-get install -y python3-pip
 RUN update-alternatives --install /usr/bin/python python /usr/bin/python3 1
 RUN update-alternatives --install /usr/bin/pip pip /usr/bin/pip3 1
 
-RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --default-toolchain nightly
+RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
 ENV PATH="/root/.cargo/bin:${PATH}"
 
 RUN /root/.cargo/bin/rustup update \
     && /root/.cargo/bin/rustup target add aarch64-unknown-linux-gnu
-
+RUN rustup default stable
 RUN mkdir /var/task
 WORKDIR /var/task
 

src/ssm.rs

@@ -31,9 +31,9 @@ pub async fn get_envs(env_vars: HashMap<String, String>) -> Result<HashMap<Strin
                         results.insert(key, value);
                     });
                 }
-                Err(error) => log::cloudwatch_metric("ssm", "error", true, Some(error.to_string())),
+                Err(error) => return Err(error), // Return error if parameter is not found
             },
-            Err(error) => log::cloudwatch_metric("ssm", "error", true, Some(error.to_string())),
+            Err(error) => return Err(anyhow::anyhow!(error.to_string())), // Return error if task fails
         }
     }
     Ok(results)
@@ -67,6 +67,7 @@ async fn ssm_get_parameter(
                     name, path, error
                 )),
             );
+            return Err(anyhow::anyhow!(error.to_string())); // Return error
         }
     }
     Ok(items)
@@ -100,7 +101,7 @@ async fn ssm_get_parameters_by_path(
                         items.insert(env_name, parameter.value.unwrap());
                     }
                 }
-                if response.next_token == None {
+                if response.next_token.is_none() {
                     break;
                 }
                 token = response.next_token;
@@ -115,7 +116,7 @@ async fn ssm_get_parameters_by_path(
                         name, path, error
                     )),
                 );
-                break;
+                return Err(anyhow::anyhow!(error.to_string())); // Return error
             }
         }
     }
@@ -127,6 +128,7 @@ mod test {
     use super::*;
     use anyhow::Result;
     use aws_sdk_ssm::model::ParameterType;
+    use std::collections::HashMap;
 
     #[tokio::test]
     async fn should_parse() -> Result<()> {
@@ -191,4 +193,14 @@ mod test {
         assert_eq!(results, expected);
         Ok(())
     }
-}
+
+    #[tokio::test]
+    async fn should_fail_if_param_not_found() {
+        let env_vars: HashMap<String, String> = HashMap::from([
+            ("NON_EXISTENT_PARAM".to_string(), "x-crypteia-ssm:/crypteia/v5/myapp/NON_EXISTENT_PARAM".to_string()),
+        ]);
+
+        let result = get_envs(env_vars).await;
+        assert!(result.is_err(), "Expected an error when parameter is not found");
+    }
+}