standardrb

Author: aidanharan

lib/active_record/connection_adapters/sqlserver/core_ext/attribute_methods.rb

@@ -15,7 +15,7 @@ def attributes_for_update(attribute_names)
 
               super(attribute_names).reject do |name|
                 column = self.class.columns_hash[name]
-                column && column.respond_to?(:is_identity?) && column.is_identity?
+                column&.respond_to?(:is_identity?) && column.is_identity?
               end
             end
           end

lib/active_record/connection_adapters/sqlserver/sql_type_metadata.rb

@@ -29,12 +29,7 @@ def ==(other)
         alias_method :eql?, :==
 
         def hash
-          TypeMetadata.hash ^
-            __getobj__.hash ^
-            is_identity.hash ^
-            is_primary.hash ^
-            table_name.hash ^
-            ordinal_position.hash
+          [TypeMetadata, __getobj__, is_identity, is_primary, table_name, ordinal_position].hash
         end
 
         private

lib/active_record/connection_adapters/sqlserver/type/date.rb

@@ -9,12 +9,12 @@ def sqlserver_type
             "date"
           end
 
-          def serialize(value)
+          def serialize(_value)
             value = super
             return value unless value.acts_like?(:date)
 
             date = super.to_formatted_s(:_sqlserver_dateformat)
-            Data.new date, self
+            Data.new(date, self)
           end
 
           def deserialize(value)

lib/active_record/connection_adapters/sqlserver/type/datetime.rb

@@ -11,13 +11,12 @@ def sqlserver_type
             "datetime"
           end
 
-          def serialize(value)
+          def serialize(_value)
             value = super
             return value unless value.acts_like?(:time)
 
             datetime = "#{value.to_formatted_s(:_sqlserver_datetime)}.#{quote_fractional(value)}"
-
-            Data.new datetime, self
+            Data.new(datetime, self)
           end
 
           def deserialize(value)

lib/active_record/connection_adapters/sqlserver_column.rb

@@ -58,12 +58,7 @@ def ==(other)
         alias_method :eql?, :==
 
         def hash
-          Column.hash ^
-            super.hash ^
-            is_identity?.hash ^
-            is_primary?.hash ^
-            table_name.hash ^
-            ordinal_position.hash
+          [Column, super, is_identity?, is_primary?, table_name, ordinal_position].hash
         end
 
         private

test/cases/column_test_sqlserver.rb

@@ -45,9 +45,9 @@ class MigrationTestSQLServer < ActiveRecord::TestCase
 
     it "not drop the default constraint if just renaming" do
       find_default = lambda do
-        connection.execute_procedure(:sp_helpconstraint, "sst_string_defaults", "nomsg").select do |row|
+        connection.execute_procedure(:sp_helpconstraint, "sst_string_defaults", "nomsg").reverse.find do |row|
           row["constraint_type"] == "DEFAULT on column string_with_pretend_paren_three"
-        end.last
+        end
       end
       default_before = find_default.call
       connection.change_column :sst_string_defaults, :string_with_pretend_paren_three, :string, limit: 255

test/cases/migration_test_sqlserver.rb

@@ -20,11 +20,11 @@ def coerce_tests!(*methods)
 
         def coerce_all_tests!
           instance_methods(false).each do |method|
-            next unless /\Atest/.match?(method.to_s)
+            next unless method.to_s.start_with?("test")
 
             undef_method(method)
           end
-          STDOUT.puts "🙉 🙈 🙊  Undefined all tests: #{name}"
+          $stdout.puts "🙉 🙈 🙊  Undefined all tests: #{name}"
         end
 
         private
@@ -43,9 +43,9 @@ def coerced_test_warning(test_to_coerce)
             end
 
             if result.blank?
-              STDOUT.puts "🐳  Unfound coerced test: #{name}##{m}"
+              $stdout.puts "🐳  Unfound coerced test: #{name}##{m}"
             else
-              STDOUT.puts "🐵  Undefined coerced test: #{name}##{m}"
+              $stdout.puts "🐵  Undefined coerced test: #{name}##{m}"
             end
           end
         end