From 7979fb1cd30f90047aa546a5c6814076a3628061 Mon Sep 17 00:00:00 2001 From: alinkedd Date: Tue, 20 Feb 2024 23:45:13 +0200 Subject: [PATCH 1/3] Update gh actions --- .github/workflows/analyze.yml | 2 +- .github/workflows/analyze_comment.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/analyze.yml b/.github/workflows/analyze.yml index b1ef428d0ce..5560f1efa6c 100644 --- a/.github/workflows/analyze.yml +++ b/.github/workflows/analyze.yml @@ -55,7 +55,7 @@ jobs: name: bundle_analysis.json - name: Download base branch bundle stats - uses: dawidd6/action-download-artifact@v2 + uses: dawidd6/action-download-artifact@v6 if: success() && github.event.number with: workflow: analyze.yml diff --git a/.github/workflows/analyze_comment.yml b/.github/workflows/analyze_comment.yml index 5a3047cfc81..32e57f492ef 100644 --- a/.github/workflows/analyze_comment.yml +++ b/.github/workflows/analyze_comment.yml @@ -14,7 +14,7 @@ jobs: github.event.workflow_run.conclusion == 'success' }} steps: - name: Download base branch bundle stats - uses: dawidd6/action-download-artifact@v2 + uses: dawidd6/action-download-artifact@v6 with: workflow: analyze.yml run_id: ${{ github.event.workflow_run.id }} @@ -22,7 +22,7 @@ jobs: path: analysis_comment.txt - name: Download PR number - uses: dawidd6/action-download-artifact@v2 + uses: dawidd6/action-download-artifact@v6 with: workflow: analyze.yml run_id: ${{ github.event.workflow_run.id }} From 776f429cece374b56c0b0deb6593a2b3d9af9f45 Mon Sep 17 00:00:00 2001 From: alinkedd Date: Tue, 20 Feb 2024 23:49:21 +0200 Subject: [PATCH 2/3] Fix warning of missing analysis comment artifact --- .github/workflows/analyze.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/analyze.yml b/.github/workflows/analyze.yml index 5560f1efa6c..f28c3991356 100644 --- a/.github/workflows/analyze.yml +++ b/.github/workflows/analyze.yml @@ -82,6 +82,7 @@ jobs: - name: Upload analysis comment uses: actions/upload-artifact@v4 + if: success() && github.event.number with: name: analysis_comment.txt path: .next/analyze/__bundle_analysis_comment.txt From 60e7311930954274bca3f6f1be26e35f726d67ba Mon Sep 17 00:00:00 2001 From: alinkedd Date: Tue, 20 Feb 2024 23:56:18 +0200 Subject: [PATCH 3/3] Fix comment action failing on default branch --- .github/workflows/analyze_comment.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/analyze_comment.yml b/.github/workflows/analyze_comment.yml index 32e57f492ef..341769d9ed3 100644 --- a/.github/workflows/analyze_comment.yml +++ b/.github/workflows/analyze_comment.yml @@ -10,8 +10,8 @@ jobs: comment: runs-on: ubuntu-latest if: > - ${{ github.event.workflow_run.event == 'pull_request' && - github.event.workflow_run.conclusion == 'success' }} + github.event.workflow_run.event == 'pull_request' && + github.event.workflow_run.conclusion == 'success' steps: - name: Download base branch bundle stats uses: dawidd6/action-download-artifact@v6